[PR #4200] [MERGED] unblock tor support in brave #5060

New issue

Closed

opened 2026-05-05 10:31:33 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:31:33 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4200
Author: @ghost
Created: 4/16/2021
Status: ✅ Merged
Merged: 4/18/2021
Merged by: @undefined

Base: master ← Head: brave-tor

📝 Commits (5)

31c9a0b opt-in for brave's native tor support
bb618f8 fix brave's native tor support
2158f05 warn about potential tor breakage when using apparmor
987888d update comment for opting in to tor
86bf20f move brave's tor apparmor fix in brave.profile

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 etc/apparmor/firejail-local (+3 -0)
📝 etc/profile-a-l/brave.profile (+4 -1)

📄 Description

Fixes #4190. Instead of dropping apparmor here, it's better to add a comment directly into brave.profile. This keeps other apps including in chromium-common.profile. As the latter is included by profiles other than brave, this might not be the most elegant way to handle this. Open to suggestions!
UPDATE: changed the fix by adding instructions on how to opt-in to brave + tor into brave.profile. No need to affect all of the other apps that include chromium-common.profile.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4200 **Author:** [@ghost](https://github.com/ghost) **Created:** 4/16/2021 **Status:** ✅ Merged **Merged:** 4/18/2021 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `brave-tor` --- ### 📝 Commits (5) - [`31c9a0b`](https://github.com/netblue30/firejail/commit/31c9a0b692b414f5079bcbe5e5671e91d52eac4f) opt-in for brave's native tor support - [`bb618f8`](https://github.com/netblue30/firejail/commit/bb618f8d60a7c8f0eeb83f25cd70c201b672b422) fix brave's native tor support - [`2158f05`](https://github.com/netblue30/firejail/commit/2158f052aadc023d725a4928b71f1f8be4e7bbfc) warn about potential tor breakage when using apparmor - [`987888d`](https://github.com/netblue30/firejail/commit/987888dee6f80b60e51e7c0b7c1c90116a8b9425) update comment for opting in to tor - [`86bf20f`](https://github.com/netblue30/firejail/commit/86bf20f85d3baee7b94251052de862ccc39a417e) move brave's tor apparmor fix in brave.profile ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `etc/apparmor/firejail-local` (+3 -0) 📝 `etc/profile-a-l/brave.profile` (+4 -1) </details> ### 📄 Description Fixes #4190. Instead of dropping apparmor here, it's better to add a comment directly into brave.profile. This keeps other apps including in chromium-common.profile. As the latter is included by profiles other than brave, this might not be the most elegant way to handle this. Open to suggestions! UPDATE: changed the fix by adding instructions on how to opt-in to brave + tor into brave.profile. No need to affect all of the other apps that include chromium-common.profile. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:31:33 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:36:49 -06:00

[PR #5060] [MERGED] build(deps): bump github/codeql-action from 1.1.4 to 1.1.5 #5348

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5060

No description provided.

Rows
Columns