[PR #4161] [MERGED] allow notifications + comment fixes #5047

New issue

Closed

opened 2026-05-05 10:31:20 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:31:20 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4161
Author: @ghost
Created: 4/4/2021
Status: ✅ Merged
Merged: 4/4/2021
Merged by: @undefined

Base: master ← Head: signal-desktop

📝 Commits (2)

dc92c87 allow notifications + comment fixes
f835f7e drop some stuff based on discussion with @rusty-snake

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 etc/profile-m-z/signal-desktop.profile (+5 -4)

📄 Description

Inspired by #4158.

Regarding the comment:

# Disabled until someone reported positive feedback
#include whitelist-runuser-common.inc
#include whitelist-usr-share-common.inc
#ignore private-cache --> signal-desktop doesn't use ~/.cache

IMO we can drop these. Both whitelist-runuser-common.inc and whitelist-usr-share-common.inc are already getting included via electron.profile and that seems to work as expected. On my Arch Linux box signal-desktop doesn't use ~/.cache so it should be safe to keep private-cache as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4161 **Author:** [@ghost](https://github.com/ghost) **Created:** 4/4/2021 **Status:** ✅ Merged **Merged:** 4/4/2021 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `signal-desktop` --- ### 📝 Commits (2) - [`dc92c87`](https://github.com/netblue30/firejail/commit/dc92c87e9d3f16e0cddd1442757583c4d00b57ef) allow notifications + comment fixes - [`f835f7e`](https://github.com/netblue30/firejail/commit/f835f7e798e0dada8fcace3d49d9186afb30ef5e) drop some stuff based on discussion with @rusty-snake ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-m-z/signal-desktop.profile` (+5 -4) </details> ### 📄 Description Inspired by #4158. Regarding the comment: ``` # Disabled until someone reported positive feedback #include whitelist-runuser-common.inc #include whitelist-usr-share-common.inc #ignore private-cache --> signal-desktop doesn't use ~/.cache ``` IMO we can drop these. Both `whitelist-runuser-common.inc` and `whitelist-usr-share-common.inc` are already getting included via electron.profile and that seems to work as expected. On my Arch Linux box signal-desktop doesn't use ~/.cache so it should be safe to keep `private-cache` as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:31:20 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5047

No description provided.

Rows
Columns