[PR #4035] [MERGED] Improve error messages #5006

New issue

Closed

opened 2026-05-05 10:30:33 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:30:33 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4035
Author: @Tomin1
Created: 3/3/2021
Status: ✅ Merged
Merged: 3/3/2021
Merged by: @reinerh

Base: master ← Head: few_fixes

📝 Commits (2)

732e217 Improve error reporting while mounting
dc48b88 Use strerror(errno) instead of %m

📊 Changes

2 files changed (+8 additions, -6 deletions)

View changed files

📝 src/firejail/fs_etc.c (+6 -4)
📝 src/firejail/sandbox.c (+2 -2)

📄 Description

I sent some changes recently (#3998) and now I noticed that there were some minor things that could have been better.

The first commit moves error message of missing directory while mounting after debug logging so that it's easy to see when the error happens and adds a cause message. The second commit changes %m usages introduced by the changes I made. While %m is reentrant and allows very nice and clean code, it's not consistent with the rest of firejail and also not portable across libc implementations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4035 **Author:** [@Tomin1](https://github.com/Tomin1) **Created:** 3/3/2021 **Status:** ✅ Merged **Merged:** 3/3/2021 **Merged by:** [@reinerh](https://github.com/reinerh) **Base:** `master` ← **Head:** `few_fixes` --- ### 📝 Commits (2) - [`732e217`](https://github.com/netblue30/firejail/commit/732e217c3e57a79958f114024a21a7b6a102f188) Improve error reporting while mounting - [`dc48b88`](https://github.com/netblue30/firejail/commit/dc48b88db9f1c467f13ccc501e317179d26804d2) Use strerror(errno) instead of %m ### 📊 Changes **2 files changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/fs_etc.c` (+6 -4) 📝 `src/firejail/sandbox.c` (+2 -2) </details> ### 📄 Description I sent some changes recently (#3998) and now I noticed that there were some minor things that could have been better. The first commit moves error message of missing directory while mounting after debug logging so that it's easy to see when the error happens and adds a cause message. The second commit changes %m usages introduced by the changes I made. While %m is reentrant and allows very nice and clean code, it's not consistent with the rest of firejail and also not portable across libc implementations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:30:33 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5006

No description provided.

Rows
Columns