[PR #4009] [MERGED] Allow changing protocol list after initial set #4991

New issue

Closed

opened 2026-05-05 10:30:17 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:30:17 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4009
Author: @Tomin1
Created: 2/25/2021
Status: ✅ Merged
Merged: 2/26/2021
Merged by: @netblue30

Base: master ← Head: protocol_list_improvements

📝 Commits (2)

cddc483 Add utility functions for handling comma separated lists
5ffd928 Allow changing "protocol" list after initial set

📊 Changes

3 files changed (+151 additions, -18 deletions)

View changed files

📝 src/firejail/firejail.h (+3 -0)
📝 src/firejail/main.c (+4 -9)
📝 src/firejail/profile.c (+144 -9)

📄 Description

Firejail uses set-once logic for protocol list. This makes it impossible to accumulate list of allowed protocols from multiple include files. Instead of mandating that protocol is set once, allow constructing the list from multiple protocol rules.

These patches were part of Sailfish's firejail packaging. These were developed as part of implementing firejail sandboxing in Sailfish OS and just like the previous patches these were written by my colleague and previously reviewed by me or one of my other colleagues. See also #3960 for discussion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4009 **Author:** [@Tomin1](https://github.com/Tomin1) **Created:** 2/25/2021 **Status:** ✅ Merged **Merged:** 2/26/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `protocol_list_improvements` --- ### 📝 Commits (2) - [`cddc483`](https://github.com/netblue30/firejail/commit/cddc48322240e83104ec583d5551a68523470833) Add utility functions for handling comma separated lists - [`5ffd928`](https://github.com/netblue30/firejail/commit/5ffd9287fc12fe8fca1a7452adeb92fa9a5b0b7e) Allow changing "protocol" list after initial set ### 📊 Changes **3 files changed** (+151 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/firejail.h` (+3 -0) 📝 `src/firejail/main.c` (+4 -9) 📝 `src/firejail/profile.c` (+144 -9) </details> ### 📄 Description Firejail uses set-once logic for protocol list. This makes it impossible to accumulate list of allowed protocols from multiple include files. Instead of mandating that protocol is set once, allow constructing the list from multiple protocol rules. These patches were part of [Sailfish's firejail packaging](https://github.com/sailfishos/firejail/). These were developed as part of implementing firejail sandboxing in Sailfish OS and just like the previous patches these were written by my colleague and previously reviewed by me or one of my other colleagues. See also #3960 for discussion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:30:17 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4991

No description provided.

Rows
Columns