[PR #3998] [MERGED] Upstreaming a set of fixes from Sailfish's packaging #4984

New issue

Closed

opened 2026-05-05 10:30:11 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:30:11 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3998
Author: @Tomin1
Created: 2/19/2021
Status: ✅ Merged
Merged: 2/24/2021
Merged by: @netblue30

Base: master ← Head: first_fixes

📝 Commits (5)

80b73e7 Fix symlinks that go though /proc/self
eeec209 fcopy: Fix memory leaks
70cc108 sandbox: Do not leave file mounts underneath private-etc
2e95e9e Add missing linefeeds in stderr logging
89ba89b Add checks to fs_private_dir_mount

📊 Changes

7 files changed (+96 additions, -15 deletions)

View changed files

📝 src/fcopy/main.c (+48 -8)
📝 src/firejail/firejail.h (+2 -0)
📝 src/firejail/fs_etc.c (+19 -1)
📝 src/firejail/fs_mkdir.c (+2 -2)
📝 src/firejail/main.c (+1 -1)
📝 src/firejail/network_main.c (+1 -1)
📝 src/firejail/sandbox.c (+23 -2)

📄 Description

This is upstreaming first set of fixes from Sailfish's firejail packaging. These were developed as part of implementing firejail sandboxing in Sailfish OS. See also #3960 for discussion.

These are general fixes to firejail touching logging, private-etc, memory handing and symbolic link construction around /proc filesystem. Please see the commit messages for explanations. These were written by my colleague and previously reviewed by me or one of my other colleagues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3998 **Author:** [@Tomin1](https://github.com/Tomin1) **Created:** 2/19/2021 **Status:** ✅ Merged **Merged:** 2/24/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `first_fixes` --- ### 📝 Commits (5) - [`80b73e7`](https://github.com/netblue30/firejail/commit/80b73e75d82ec618625c5278828bb5b9b32d3114) Fix symlinks that go though /proc/self - [`eeec209`](https://github.com/netblue30/firejail/commit/eeec209467bbfbf6d6bd138246e1c8d184b4c817) fcopy: Fix memory leaks - [`70cc108`](https://github.com/netblue30/firejail/commit/70cc108688f4e1f654534bf58cafe1caff3fc0e0) sandbox: Do not leave file mounts underneath private-etc - [`2e95e9e`](https://github.com/netblue30/firejail/commit/2e95e9e2105ee9db2a52cf3e1c02a1963a2283f1) Add missing linefeeds in stderr logging - [`89ba89b`](https://github.com/netblue30/firejail/commit/89ba89bacf51eee6284397f4d01ff8759bddebe7) Add checks to fs_private_dir_mount ### 📊 Changes **7 files changed** (+96 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/fcopy/main.c` (+48 -8) 📝 `src/firejail/firejail.h` (+2 -0) 📝 `src/firejail/fs_etc.c` (+19 -1) 📝 `src/firejail/fs_mkdir.c` (+2 -2) 📝 `src/firejail/main.c` (+1 -1) 📝 `src/firejail/network_main.c` (+1 -1) 📝 `src/firejail/sandbox.c` (+23 -2) </details> ### 📄 Description This is upstreaming first set of fixes from [Sailfish's firejail packaging](https://github.com/sailfishos/firejail/). These were developed as part of implementing firejail sandboxing in Sailfish OS. See also #3960 for discussion. These are general fixes to firejail touching logging, private-etc, memory handing and symbolic link construction around /proc filesystem. Please see the commit messages for explanations. These were written by my colleague and previously reviewed by me or one of my other colleagues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:30:11 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4984

No description provided.

Rows
Columns