[PR #4001] [MERGED] profiles: signal-desktop: remove invalid ignore include-xdg.inc #4982

New issue

Closed

opened 2026-05-05 10:30:10 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:30:10 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4001
Author: @kmk3
Created: 2/21/2021
Status: ✅ Merged
Merged: 2/24/2021
Merged by: @netblue30

Base: master ← Head: fix-signal-xdg-ignore

📝 Commits (1)

9616146 signal-desktop.profile: fix typo of disable-xdg.profile

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 etc/profile-m-z/signal-desktop.profile (+0 -1)

📄 Description

Added on commit f4f676745 ("Refactor electron.profile and electron based
programs (#3807)").

This appears to be the only instance of that:

$ grep -Fnr 'include-xdg' etc
etc/profile-m-z/signal-desktop.profile:9:ignore include-xdg.inc

Credits go to syntax highlighting on vim.

Also, note that the file says this:

# Disabled until someone reported positive feedback
ignore include-xdg.inc

So if there was no negative feedback, should xdg dirs (other than
${DOWNLOADS}, that is) be allowed or should we just remove that line instead?
As all this PR would do is allow xdg dirs for the first time since at least
commit f4f676745.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4001 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/21/2021 **Status:** ✅ Merged **Merged:** 2/24/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-signal-xdg-ignore` --- ### 📝 Commits (1) - [`9616146`](https://github.com/netblue30/firejail/commit/961614626db5ba310c7b010374eb0468ea1571ed) signal-desktop.profile: fix typo of disable-xdg.profile ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-m-z/signal-desktop.profile` (+0 -1) </details> ### 📄 Description Added on commit f4f676745 ("Refactor electron.profile and electron based programs (#3807)"). This appears to be the only instance of that: $ grep -Fnr 'include-xdg' etc etc/profile-m-z/signal-desktop.profile:9:ignore include-xdg.inc Credits go to syntax highlighting on vim. --- Also, note that the file says this: ```firejail # Disabled until someone reported positive feedback ignore include-xdg.inc ``` So if there was no negative feedback, should xdg dirs (other than `${DOWNLOADS}`, that is) be allowed or should we just remove that line instead? As all this PR would do is allow xdg dirs for the first time since at least commit f4f676745. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:30:10 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4982

No description provided.

Rows
Columns