[PR #3964] [MERGED] Revert "etc: use ${DOCUMENTS} macro where appropriate" #4968

New issue

Closed

opened 2026-05-05 10:29:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:29:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3964
Author: @kmk3
Created: 2/9/2021
Status: ✅ Merged
Merged: 2/9/2021
Merged by: @rusty-snake

Base: master ← Head: revert-macro

📝 Commits (1)

cdeb623 Revert "etc: use ${DOCUMENTS} macro where appropriate"

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 etc/profile-a-l/keepassxc.profile (+3 -3)
📝 etc/profile-m-z/Mathematica.profile (+2 -2)

📄 Description

This reverts commit 5df1f27c63.

That commit breaks things, as pointed out by @rusty-snake1:

@kmk3 @glitsj16 The xdg macros are treated literally if they have sub
components (#2359):
Error: "${DOCUMENTS}/KeePassXC" is an invalid filename: rejected character: "{"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3964 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/9/2021 **Status:** ✅ Merged **Merged:** 2/9/2021 **Merged by:** [@rusty-snake](https://github.com/rusty-snake) **Base:** `master` ← **Head:** `revert-macro` --- ### 📝 Commits (1) - [`cdeb623`](https://github.com/netblue30/firejail/commit/cdeb623e83f57f33712747572d4282b54dbf149f) Revert "etc: use ${DOCUMENTS} macro where appropriate" ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-a-l/keepassxc.profile` (+3 -3) 📝 `etc/profile-m-z/Mathematica.profile` (+2 -2) </details> ### 📄 Description This reverts commit 5df1f27c638c487dfd664ea3a0f756565e1e57bd. That commit breaks things, as pointed out by @rusty-snake[1]: > @kmk3 @glitsj16 The xdg macros are treated literally if they have sub > components (#2359): > > ``` > Error: "${DOCUMENTS}/KeePassXC" is an invalid filename: rejected character: "{" > ``` [1]: https://github.com/netblue30/firejail/commit/3fa2927c3c1c5cf583864746538ea791c1ba2dc4#commitcomment-46913219 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:29:55 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4968

No description provided.

Rows
Columns