[PR #3820] [MERGED] Refactor archivers #4895

New issue

Closed

opened 2026-05-05 10:28:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:28:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3820
Author: @ghost
Created: 12/14/2020
Status: ✅ Merged
Merged: 12/15/2020
Merged by: @undefined

Base: master ← Head: refactor-archivers

📝 Commits (10+)

113fa46 Create archiver-common.inc
cfc13b4 add apparmor to archiver-common.inc
0277a05 refactor 7z.profile
01948fc refactor ar.profile
91b5ace refactor atool.profile
79f6eb0 refactor bsdtar.profile
28f536a refactor cpio.profile
6274526 refactor gzip.profile
95a12b6 refactor tar.profile
9f94bd8 refactor unrar.profile

📊 Changes

12 files changed (+72 additions, -382 deletions)

View changed files

➕ etc/inc/archiver-common.inc (+44 -0)
📝 etc/profile-a-l/7z.profile (+3 -36)
📝 etc/profile-a-l/ar.profile (+1 -37)
📝 etc/profile-a-l/atool.profile (+3 -35)
📝 etc/profile-a-l/bsdtar.profile (+3 -36)
📝 etc/profile-a-l/cpio.profile (+4 -34)
📝 etc/profile-a-l/gzip.profile (+2 -37)
📝 etc/profile-m-z/tar.profile (+2 -36)
📝 etc/profile-m-z/unrar.profile (+3 -33)
📝 etc/profile-m-z/unzip.profile (+2 -32)
📝 etc/profile-m-z/xzdec.profile (+3 -32)
📝 etc/profile-m-z/zstd.profile (+2 -34)

📄 Description

Introduce archive-common.inc: common file for all archivers.
For now this WIP simply recreates existing archiver profiles.
It's intention is to:

simplify adding new archiver profile(s);
review potential inconsistencies in existing archiver profile(s).
E.g. most have nogroups and have noroot commented, but a few divert from this pattern. I intend to do a follow-up review after extended testing, so for now this is a WIP.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3820 **Author:** [@ghost](https://github.com/ghost) **Created:** 12/14/2020 **Status:** ✅ Merged **Merged:** 12/15/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `refactor-archivers` --- ### 📝 Commits (10+) - [`113fa46`](https://github.com/netblue30/firejail/commit/113fa461e0dddc76528e15bd80e6d2f34d9c13d3) Create archiver-common.inc - [`cfc13b4`](https://github.com/netblue30/firejail/commit/cfc13b47eb2faff110b2e05c7e53377e5b9abf14) add apparmor to archiver-common.inc - [`0277a05`](https://github.com/netblue30/firejail/commit/0277a053fade2dd34364b095a9a9101ed10083c1) refactor 7z.profile - [`01948fc`](https://github.com/netblue30/firejail/commit/01948fc154ccf8ba63fcf2c97769e47f83aa8b23) refactor ar.profile - [`91b5ace`](https://github.com/netblue30/firejail/commit/91b5acebab19bf72072e5be061af0ef7af4c5b70) refactor atool.profile - [`79f6eb0`](https://github.com/netblue30/firejail/commit/79f6eb063d7daea9e9a90bcf1afe8e2839d84a29) refactor bsdtar.profile - [`28f536a`](https://github.com/netblue30/firejail/commit/28f536af9d092c81d5cb9ec99fb603188faece83) refactor cpio.profile - [`6274526`](https://github.com/netblue30/firejail/commit/62745267d83335838c66d22a399b42ce2b761fc1) refactor gzip.profile - [`95a12b6`](https://github.com/netblue30/firejail/commit/95a12b6b9f00aaa7b63dc189c00dc84542256236) refactor tar.profile - [`9f94bd8`](https://github.com/netblue30/firejail/commit/9f94bd8265fc2a3c03dc17d0dedad0f0e83c8596) refactor unrar.profile ### 📊 Changes **12 files changed** (+72 additions, -382 deletions) <details> <summary>View changed files</summary> ➕ `etc/inc/archiver-common.inc` (+44 -0) 📝 `etc/profile-a-l/7z.profile` (+3 -36) 📝 `etc/profile-a-l/ar.profile` (+1 -37) 📝 `etc/profile-a-l/atool.profile` (+3 -35) 📝 `etc/profile-a-l/bsdtar.profile` (+3 -36) 📝 `etc/profile-a-l/cpio.profile` (+4 -34) 📝 `etc/profile-a-l/gzip.profile` (+2 -37) 📝 `etc/profile-m-z/tar.profile` (+2 -36) 📝 `etc/profile-m-z/unrar.profile` (+3 -33) 📝 `etc/profile-m-z/unzip.profile` (+2 -32) 📝 `etc/profile-m-z/xzdec.profile` (+3 -32) 📝 `etc/profile-m-z/zstd.profile` (+2 -34) </details> ### 📄 Description Introduce `archive-common.inc`: common file for all archivers. For now this WIP simply recreates existing archiver profiles. It's intention is to: - simplify adding new archiver profile(s); - review potential inconsistencies in existing archiver profile(s). E.g. most have nogroups and have noroot commented, but a few divert from this pattern. I intend to do a follow-up review after extended testing, so for now this is a WIP. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:28:32 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4895

No description provided.

Rows
Columns