[PR #3692] [CLOSED] let tests fail build #4850

New issue

Closed

opened 2026-05-05 10:27:43 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:27:43 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3692
Author: @reinerh
Created: 10/24/2020
Status: ❌ Closed

Base: master ← Head: tests

📝 Commits (5)

cd75258 refactor test targets and let build fail on test errors
300efec let github CI run tests
c2306d9 add new Makefile.in to distributed files
8ec7724 include tests in rpm source tarball
527b680 increate timeout in xz.dec

📊 Changes

9 files changed (+43 additions, -53 deletions)

View changed files

📝 .github/workflows/build.yml (+7 -3)
📝 Makefile.in (+16 -46)
📝 configure (+2 -1)
📝 configure.ac (+1 -1)
📝 platform/rpm/mkrpm.sh (+1 -1)
➕ test/Makefile.in (+10 -0)
📝 test/sysutils/less.exp (+1 -0)
📝 test/sysutils/xz.exp (+4 -1)
📝 test/utils/man.exp (+1 -0)

📄 Description

This change simplifies the test targets, as the test names need to be specified only once, instead of repeating the targets for each test.
It will now also check the tests for errors and cause a build failure, as they currently seem to not get noticed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3692 **Author:** [@reinerh](https://github.com/reinerh) **Created:** 10/24/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tests` --- ### 📝 Commits (5) - [`cd75258`](https://github.com/netblue30/firejail/commit/cd752585e030c01404dde57a5aae211829e84882) refactor test targets and let build fail on test errors - [`300efec`](https://github.com/netblue30/firejail/commit/300efec3510971d61c4a4aecb90eda3cdaff8499) let github CI run tests - [`c2306d9`](https://github.com/netblue30/firejail/commit/c2306d9616be65c8df7cfb99cef1af9e909ec324) add new Makefile.in to distributed files - [`8ec7724`](https://github.com/netblue30/firejail/commit/8ec77242d97211985542e22d3dc33f7fc00e53d5) include tests in rpm source tarball - [`527b680`](https://github.com/netblue30/firejail/commit/527b680a6384b0e6d2f91e710602115b28c56c8e) increate timeout in xz.dec ### 📊 Changes **9 files changed** (+43 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+7 -3) 📝 `Makefile.in` (+16 -46) 📝 `configure` (+2 -1) 📝 `configure.ac` (+1 -1) 📝 `platform/rpm/mkrpm.sh` (+1 -1) ➕ `test/Makefile.in` (+10 -0) 📝 `test/sysutils/less.exp` (+1 -0) 📝 `test/sysutils/xz.exp` (+4 -1) 📝 `test/utils/man.exp` (+1 -0) </details> ### 📄 Description This change simplifies the test targets, as the test names need to be specified only once, instead of repeating the targets for each test. It will now also check the tests for errors and cause a build failure, as they currently seem to not get noticed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:27:43 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4850

No description provided.

Rows
Columns