[PR #3674] [MERGED] Apply --rmenv immediately to help to avoid the env var length check #4844

New issue

Closed

opened 2026-05-05 10:27:37 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:27:37 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3674
Author: @topimiettinen
Created: 10/15/2020
Status: ✅ Merged
Merged: 10/17/2020
Merged by: @netblue30

Base: master ← Head: rmenv-apply-early

📝 Commits (1)

aabd38f Apply --rmenv immediately to help to avoid the env var length check

📊 Changes

2 files changed (+7 additions, -2 deletions)

View changed files

📝 src/firejail/main.c (+6 -2)
📝 src/firejail/profile.c (+1 -0)

📄 Description

Remove environment variables with --rmenv (and profile rmenv)
immediately. This fixes removing long environment variables (LS_COLORS
generated by vivid), previously the length filter would trip before
the command was processed.

This changes user visible behavior slightly, for example --rmenv=LANG
now applies also to Firejail, while earlier it would only apply to
sandboxed program.

Closes #3673.

Signed-off-by: Topi Miettinen toiwoton@gmail.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3674 **Author:** [@topimiettinen](https://github.com/topimiettinen) **Created:** 10/15/2020 **Status:** ✅ Merged **Merged:** 10/17/2020 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `rmenv-apply-early` --- ### 📝 Commits (1) - [`aabd38f`](https://github.com/netblue30/firejail/commit/aabd38f4972de076354991ffda4f5ce5b7f59d7e) Apply --rmenv immediately to help to avoid the env var length check ### 📊 Changes **2 files changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+6 -2) 📝 `src/firejail/profile.c` (+1 -0) </details> ### 📄 Description Remove environment variables with --rmenv (and profile rmenv) immediately. This fixes removing long environment variables (LS_COLORS generated by vivid), previously the length filter would trip before the command was processed. This changes user visible behavior slightly, for example --rmenv=LANG now applies also to Firejail, while earlier it would only apply to sandboxed program. Closes #3673. Signed-off-by: Topi Miettinen <toiwoton@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:27:37 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4844

No description provided.

Rows
Columns