[PR #3660] [MERGED] Fix AppArmor 3.0 support (closes #3659) #4838

New issue

Closed

opened 2026-05-05 10:27:31 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:27:31 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3660
Author: @kris7t
Created: 10/10/2020
Status: ✅ Merged
Merged: 10/10/2020
Merged by: @kris7t

Base: master ← Head: apparmor-run

📝 Commits (1)

bba750c Fix AppArmor 3.0 support (closes #3659)

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 etc/apparmor/firejail-default (+4 -0)

📄 Description

AppArmor introduces the @{run} variable, which is used in
<abstractions/dbus-strict> and <abstractions/dbus-session-strict> among
other places. Thus, we must #include <tunables/run> to be able to call
these abstractions.

Standard profiles rely on <tunables/global> to include <tunables/run>, since it exists in previous AppArmor versions, too.

As an attempt at backwards compatibility, we #include if exists instead
of #include, since there is no <tunables/run> in AppArmor 2.x.

However, if exists is a relatively new feature, see e.g.
https://phabricator.kde.org/D14526
(However, do note that if exists does not appear as a new feature in
https://gitlab.com/apparmor/apparmor/-/wikis/Release_Notes_2.13).
Therefore, this commit restricts our compatibility to relatively new
(<10 months) old AppArmor releases only.

As an alternative, we could detect the AppArmor version at configure
time, and emit a firejail-default profile based on that.

Here, I opted for the simpler approach, as distributions likely to ship >10 months old AppArmor (Debian) support Firejail on their own via backports (according to https://github.com/netblue30/firejail/security/policy), anyways.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3660 **Author:** [@kris7t](https://github.com/kris7t) **Created:** 10/10/2020 **Status:** ✅ Merged **Merged:** 10/10/2020 **Merged by:** [@kris7t](https://github.com/kris7t) **Base:** `master` ← **Head:** `apparmor-run` --- ### 📝 Commits (1) - [`bba750c`](https://github.com/netblue30/firejail/commit/bba750c73469ea315d859464ddd19e495d830a72) Fix AppArmor 3.0 support (closes #3659) ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `etc/apparmor/firejail-default` (+4 -0) </details> ### 📄 Description AppArmor introduces the @{run} variable, which is used in <abstractions/dbus-strict> and <abstractions/dbus-session-strict> among other places. Thus, we must #include <tunables/run> to be able to call these abstractions. Standard profiles rely on <tunables/global> to include <tunables/run>, since it exists in previous AppArmor versions, too. ~As an attempt at backwards compatibility, we #include if exists instead of #include, since there is no <tunables/run> in AppArmor 2.x.~ ~However, if exists is a relatively new feature, see e.g. https://phabricator.kde.org/D14526 (However, do note that if exists does not appear as a new feature in https://gitlab.com/apparmor/apparmor/-/wikis/Release_Notes_2.13). Therefore, this commit restricts our compatibility to relatively new (<10 months) old AppArmor releases only.~ ~As an alternative, we could detect the AppArmor version at configure time, and emit a firejail-default profile based on that.~ ~Here, I opted for the simpler approach, as distributions likely to ship >10 months old AppArmor (Debian) support Firejail on their own via backports (according to https://github.com/netblue30/firejail/security/policy), anyways.~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:27:31 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:35:15 -06:00

[PR #4838] [MERGED] profiles: fix librewolf #5263

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4838

No description provided.

Rows
Columns