[PR #3653] [MERGED] fix command test in jail_prober.py #4836

New issue

Closed

opened 2026-05-05 10:27:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:27:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3653
Author: @briaeros
Created: 10/5/2020
Status: ✅ Merged
Merged: 10/10/2020
Merged by: @Fred-Barclay

Base: master ← Head: master

📝 Commits (2)

f78f8cf fix command test in jail_prober.py
869e5e7 jail_prober : first pass without any argument

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 contrib/jail_prober.py (+11 -3)

📄 Description

In jail_prober.py, a bug prevent a correct testing :
Argument of the firejail command aren't tested when they are presented to the user, but one loop after (once they're added to "goodargs" array).
This also imply that they're not removed if they doesn't work

This little modification correct these two problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3653 **Author:** [@briaeros](https://github.com/briaeros) **Created:** 10/5/2020 **Status:** ✅ Merged **Merged:** 10/10/2020 **Merged by:** [@Fred-Barclay](https://github.com/Fred-Barclay) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`f78f8cf`](https://github.com/netblue30/firejail/commit/f78f8cfbdef22b25be4ffe1fae4a4cc404bfbf5c) fix command test in jail_prober.py - [`869e5e7`](https://github.com/netblue30/firejail/commit/869e5e749f958cbd70802da571b509f2fd50d335) jail_prober : first pass without any argument ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `contrib/jail_prober.py` (+11 -3) </details> ### 📄 Description In jail_prober.py, a bug prevent a correct testing : Argument of the firejail command aren't tested when they are presented to the user, but one loop after (once they're added to "goodargs" array). This also imply that they're not removed if they doesn't work This little modification correct these two problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:27:27 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4836

No description provided.

Rows
Columns