[PR #3574] [MERGED] annotate some functions as non-returning #4817

New issue

Closed

opened 2026-05-05 10:27:09 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:27:09 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3574
Author: @reinerh
Created: 8/8/2020
Status: ✅ Merged
Merged: 8/8/2020
Merged by: @reinerh

Base: master ← Head: noreturn

📝 Commits (1)

04605a7 annotate some functions as non-returning

📊 Changes

11 files changed (+34 additions, -41 deletions)

View changed files

📝 src/firejail/arp.c (+1 -3)
📝 src/firejail/firejail.h (+17 -18)
📝 src/firejail/join.c (+1 -1)
📝 src/firejail/main.c (+1 -2)
📝 src/firejail/protocol.c (+1 -1)
📝 src/firejail/sbox.c (+1 -1)
📝 src/firejail/x11.c (+2 -2)
📝 src/firemon/firemon.h (+3 -3)
📝 src/firemon/procevent.c (+5 -8)
📝 src/include/syscall.h (+1 -1)
📝 src/lib/errno.c (+1 -1)

📄 Description

I noticed some comments in the code like "// it will never get here", so I added some annotations to make this assumption also clear to the compiler.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3574 **Author:** [@reinerh](https://github.com/reinerh) **Created:** 8/8/2020 **Status:** ✅ Merged **Merged:** 8/8/2020 **Merged by:** [@reinerh](https://github.com/reinerh) **Base:** `master` ← **Head:** `noreturn` --- ### 📝 Commits (1) - [`04605a7`](https://github.com/netblue30/firejail/commit/04605a7642e4a46972ea9f1e8e1cd5c1ffe60e60) annotate some functions as non-returning ### 📊 Changes **11 files changed** (+34 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/arp.c` (+1 -3) 📝 `src/firejail/firejail.h` (+17 -18) 📝 `src/firejail/join.c` (+1 -1) 📝 `src/firejail/main.c` (+1 -2) 📝 `src/firejail/protocol.c` (+1 -1) 📝 `src/firejail/sbox.c` (+1 -1) 📝 `src/firejail/x11.c` (+2 -2) 📝 `src/firemon/firemon.h` (+3 -3) 📝 `src/firemon/procevent.c` (+5 -8) 📝 `src/include/syscall.h` (+1 -1) 📝 `src/lib/errno.c` (+1 -1) </details> ### 📄 Description I noticed some comments in the code like "// it will never get here", so I added some annotations to make this assumption also clear to the compiler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:27:09 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4817

No description provided.

Rows
Columns