mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #3572] [MERGED] hardening: run plugins with dumpable flag cleared #4816
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#4816
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/3572
Author: @smitsohu
Created: 8/6/2020
Status: ✅ Merged
Merged: 8/22/2020
Merged by: @netblue30
Base:
master← Head:dumpable📝 Commits (4)
515f344hardening: run plugins with dumpable flag cleared7d08006various x11 xorg enhancements9e3b7b9add dumpable warnings21918f6cleanup📊 Changes
16 files changed (+140 additions, -122 deletions)
View changed files
📝
Makefile.in(+8 -4)📝
src/fcopy/main.c(+6 -0)📝
src/firejail/main.c(+4 -0)📝
src/firejail/sbox.c(+1 -0)📝
src/firejail/x11.c(+69 -104)📝
src/fldd/main.c(+6 -0)📝
src/fnet/main.c(+10 -6)📝
src/fnetfilter/main.c(+5 -1)📝
src/fsec-optimize/fsec_optimize.h(+1 -0)📝
src/fsec-optimize/main.c(+6 -0)📝
src/fsec-print/fsec_print.h(+1 -0)📝
src/fsec-print/main.c(+5 -0)📝
src/fseccomp/fseccomp.h(+1 -0)📝
src/fseccomp/main.c(+11 -5)📝
src/include/common.h(+3 -0)📝
src/include/rundefs.h(+3 -2)📄 Description
The kernel clears the dumpable flag if a user has no read permission on an executable and it is owned by another user (root in this case). I omitted faudit, fbuilder and ftee for now as they are not used to configure the sandbox itself, and as this commit is going to complicate debugging efforts to some extent. By design some processes are not covered this way, most notably xauth and shell instances created by system(3). But still it should be an improvement over the current state.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.