mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #3275] [MERGED] add name or private directory being used to the window title when xpra is being used #4705
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#4705
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/3275
Author: @dmfreemon
Created: 3/11/2020
Status: ✅ Merged
Merged: 3/19/2020
Merged by: @smitsohu
Base:
master← Head:add-name-or-private-dir-to-xpra-window-title📝 Commits (2)
2556c9cadd name or basename of private directory being used to the window title when xpra is being used7f39af8handle malloc() failures; use gnu_basename() instead of basenaem()📊 Changes
1 file changed (+61 additions, -1 deletions)
View changed files
📝
src/firejail/x11.c(+61 -1)📄 Description
First, thanks for making firejail available. It is outstanding.
I use a number of different private directories, and wanted some kind of visual indication of which private directory was being used by each instance of a running firefox. This PR adds this information to the window title when xpra is being used. I find this to be very valuable for me, and maybe others will as well.
This PR may be related to at least some of this prior issues (in no particular order):
https://github.com/netblue30/firejail/issues/1983
https://github.com/netblue30/firejail/issues/1350
https://github.com/netblue30/firejail/issues/1308
https://github.com/netblue30/firejail/issues/281
https://github.com/netblue30/firejail/issues/303
https://github.com/netblue30/firejail/issues/424
https://github.com/netblue30/firejail/issues/242
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.