id #4649

New issue

Closed

opened 2026-05-05 10:24:02 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:24:02 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3114
Author: @creideiki
Created: 1/3/2020
Status: ✅ Merged
Merged: 1/5/2020
Merged by: @rusty-snake

Base: master ← Head: torbrowser-launcher-allow-id

📝 Commits (1)

45ad1c1 Allow Tor Browser to run /usr/bin/id

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 etc/torbrowser-launcher.profile (+1 -1)

📄 Description

The start-tor-browser script tries to run /usr/bin/id to check that
it isn't root before starting the browser. See
https://gitweb.torproject.org/builders/tor-browser-build.git/tree/projects/tor-browser/RelativeLink/start-tor-browser?id=41fd236bbb7d3d75a27473f927be31f7dd8fdc99#n94

If id is not in the private-bin directory, the test still works by
accident, but prints these error messages:

  ./Browser/start-tor-browser: line 94: id: command not found
  ./Browser/start-tor-browser: line 94: [: : integer expression expected

Add id to the private-bin directory to make it run as intended.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3114 **Author:** [@creideiki](https://github.com/creideiki) **Created:** 1/3/2020 **Status:** ✅ Merged **Merged:** 1/5/2020 **Merged by:** [@rusty-snake](https://github.com/rusty-snake) **Base:** `master` ← **Head:** `torbrowser-launcher-allow-id` --- ### 📝 Commits (1) - [`45ad1c1`](https://github.com/netblue30/firejail/commit/45ad1c160fce0bcea9e3b99d767a91a72cee2879) Allow Tor Browser to run /usr/bin/id ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `etc/torbrowser-launcher.profile` (+1 -1) </details> ### 📄 Description The `start-tor-browser` script tries to run `/usr/bin/id` to check that it isn't root before starting the browser. See https://gitweb.torproject.org/builders/tor-browser-build.git/tree/projects/tor-browser/RelativeLink/start-tor-browser?id=41fd236bbb7d3d75a27473f927be31f7dd8fdc99#n94 If `id` is not in the `private-bin` directory, the test still works by accident, but prints these error messages: ``` ./Browser/start-tor-browser: line 94: id: command not found ./Browser/start-tor-browser: line 94: [: : integer expression expected ``` Add `id` to the `private-bin` directory to make it run as intended. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:24:02 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4649

No description provided.

Rows
Columns