[GH-ISSUE #676] Closing Xephyr window when exiting? #464

Closed
opened 2026-05-05 05:54:52 -06:00 by gitea-mirror · 4 comments
Owner

Originally created by @vn971 on GitHub (Aug 1, 2016).
Original GitHub issue: https://github.com/netblue30/firejail/issues/676

Should firejail close its Xephyr window when exiting? The current version of firejail does NOT close the window (for me).

Behavior in question:

  • start firejail with firejail --noprofile --x11=xephyr xterm
  • close xterm by typing Ctrl+D (exit)
  • check out firejail processes. There should be none corresponding to the test
  • observe the Xephyr window still active on the desktop, though it does not allocate anything in /tmp/.X11-unix anymore.
Originally created by @vn971 on GitHub (Aug 1, 2016). Original GitHub issue: https://github.com/netblue30/firejail/issues/676 Should firejail close its Xephyr window when exiting? The current version of firejail does NOT close the window (for me). Behavior in question: - start firejail with `firejail --noprofile --x11=xephyr xterm` - close xterm by typing Ctrl+D (`exit`) - check out firejail processes. There should be none corresponding to the test - observe the Xephyr window still active on the desktop, though it does not allocate anything in `/tmp/.X11-unix` anymore.
Author
Owner

@manevich commented on GitHub (Aug 1, 2016):

-terminate option of Xephyr solves this problem.
But, for some reason -noreset (opposite of it) was added by default.
Here is quick fix.
I don't see negative consequences of this patch.
Please check it, and I will send pull request to upstream.

<!-- gh-comment-id:236565766 --> @manevich commented on GitHub (Aug 1, 2016): `-terminate` option of `Xephyr` solves this problem. But, for some reason `-noreset` (opposite of it) was added by default. [Here](https://github.com/manevich/firejail/commit/5ef59391e909ca4bdc1794b97bb9c829e30276e8) is quick fix. I don't see negative consequences of this patch. Please check it, and I will send pull request to upstream.
Author
Owner

@vn971 commented on GitHub (Aug 1, 2016):

BTW, since we already raised a question on Xephyr parameters. May it make sense to add a possibility to override firejail Xephyr parameters? Like xephyr-params-override -fullscreen -terminate in firejail.config.

<!-- gh-comment-id:236573286 --> @vn971 commented on GitHub (Aug 1, 2016): BTW, since we already raised a question on Xephyr parameters. May it make sense to add a possibility to override firejail Xephyr parameters? Like `xephyr-params-override -fullscreen -terminate` in `firejail.config`.
Author
Owner

@manevich commented on GitHub (Aug 1, 2016):

We can just change order of arguments to make xephyr-extra-params be last arg before display number, and they will override hardcoded. See 531c3401e4.

<!-- gh-comment-id:236580480 --> @manevich commented on GitHub (Aug 1, 2016): We can just change order of arguments to make `xephyr-extra-params` be last arg before display number, and they will override hardcoded. See https://github.com/manevich/firejail/commit/531c3401e4ead91118e33610c97128efdc786a53.
Author
Owner

@netblue30 commented on GitHub (Aug 2, 2016):

all merged in, thanks.

<!-- gh-comment-id:236894830 --> @netblue30 commented on GitHub (Aug 2, 2016): all merged in, thanks.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#464
No description provided.