[PR #2982] [MERGED] Move chroot entirely from path based to file descriptor based mounts #4605

New issue

Closed

opened 2026-05-05 10:23:13 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:23:13 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2982
Author: @smitsohu
Created: 9/29/2019
Status: ✅ Merged
Merged: 10/4/2019
Merged by: @netblue30

Base: master ← Head: chroot

📝 Commits (6)

9dfecbe move chroot from path based to file descriptor based mounts
94aba62 chroot module
13305e4 improve variable names
70c8924 base checks and mounts on same file descriptor
b2a91ca simplify chroot option parsing
cba04e0 improve enforce_filters warning

📊 Changes

5 files changed (+299 additions, -276 deletions)

View changed files

➕ src/firejail/chroot.c (+280 -0)
📝 src/firejail/firejail.h (+7 -3)
📝 src/firejail/fs.c (+3 -252)
📝 src/firejail/main.c (+8 -20)
📝 src/firejail/sandbox.c (+1 -1)

📄 Description

chroot directory validation was based on a file descriptor logic already, move now on top of that to file descriptor based mounts and resolv.conf copying.

Also collects all code in a new chroot module.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2982 **Author:** [@smitsohu](https://github.com/smitsohu) **Created:** 9/29/2019 **Status:** ✅ Merged **Merged:** 10/4/2019 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `chroot` --- ### 📝 Commits (6) - [`9dfecbe`](https://github.com/netblue30/firejail/commit/9dfecbe49fbbd85714d64b18933600b0d7f88ff3) move chroot from path based to file descriptor based mounts - [`94aba62`](https://github.com/netblue30/firejail/commit/94aba62229f083173cb28ffe370eaa9f3ee540b9) chroot module - [`13305e4`](https://github.com/netblue30/firejail/commit/13305e4937dd1d48b8e11c03288f1f170d4c8d7d) improve variable names - [`70c8924`](https://github.com/netblue30/firejail/commit/70c8924ebaf51387f74eba3c443ef7e870d2afc9) base checks and mounts on same file descriptor - [`b2a91ca`](https://github.com/netblue30/firejail/commit/b2a91ca47eb37581a680004411f8fa98e03ddde1) simplify chroot option parsing - [`cba04e0`](https://github.com/netblue30/firejail/commit/cba04e05bed19bb319eedc90b9cbd654f43a05a7) improve enforce_filters warning ### 📊 Changes **5 files changed** (+299 additions, -276 deletions) <details> <summary>View changed files</summary> ➕ `src/firejail/chroot.c` (+280 -0) 📝 `src/firejail/firejail.h` (+7 -3) 📝 `src/firejail/fs.c` (+3 -252) 📝 `src/firejail/main.c` (+8 -20) 📝 `src/firejail/sandbox.c` (+1 -1) </details> ### 📄 Description chroot directory validation was based on a file descriptor logic already, move now on top of that to file descriptor based mounts and resolv.conf copying. Also collects all code in a new chroot module. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:23:13 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:36:37 -06:00

[PR #5043] [MERGED] man: mention that the protocol command accumulates #5340

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4605

No description provided.

Rows
Columns