mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #670] --audit does not warn about --x11 used without --net #457
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#457
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vn971 on GitHub (Jul 31, 2016).
Original GitHub issue: https://github.com/netblue30/firejail/issues/670
See subject. Since
--x11is not secure without--net, a warning may be appropriate. Especially in--auditmode.@netblue30 commented on GitHub (Jul 31, 2016):
I'll add a test to check if x11 socket is present. For --x11 and --net combination I don't know. How do you find out from inside a sandbox if you are in a different network namespace?
@vn971 commented on GitHub (Jul 31, 2016):
@netblue30 well, why not do as you said: check x11 socket availability? It's not a strict rule (is it?), but it should work in most cases.
(Actually, I thought
--auditworks by analyzing the combined commands. But it seems it's a separate executable. Well, OK, that has some advantages, too.)@netblue30 commented on GitHub (Aug 1, 2016):
I made it a separate program so you can switch in your own test program (--audit=program_name)
@netblue30 commented on GitHub (Aug 11, 2016):
Fixed:
@vn971 commented on GitHub (Aug 12, 2016):
@netblue30 eh, I wouldn't mind auditing an X11 app.. Well anyway, if that's the easiest approach, ok.
@netblue30 commented on GitHub (Aug 12, 2016):
@manevich just put a fix in, auditing x11 sandboxes is supported in this moment!