[GH-ISSUE #670] --audit does not warn about --x11 used without --net #457

Closed
opened 2026-05-05 05:54:25 -06:00 by gitea-mirror · 6 comments
Owner

Originally created by @vn971 on GitHub (Jul 31, 2016).
Original GitHub issue: https://github.com/netblue30/firejail/issues/670

See subject. Since --x11 is not secure without --net, a warning may be appropriate. Especially in --audit mode.

Originally created by @vn971 on GitHub (Jul 31, 2016). Original GitHub issue: https://github.com/netblue30/firejail/issues/670 See subject. Since `--x11` is not secure without `--net`, a warning may be appropriate. Especially in `--audit` mode.
gitea-mirror 2026-05-05 05:54:25 -06:00
Author
Owner

@netblue30 commented on GitHub (Jul 31, 2016):

I'll add a test to check if x11 socket is present. For --x11 and --net combination I don't know. How do you find out from inside a sandbox if you are in a different network namespace?

<!-- gh-comment-id:236432164 --> @netblue30 commented on GitHub (Jul 31, 2016): I'll add a test to check if x11 socket is present. For --x11 and --net combination I don't know. How do you find out from inside a sandbox if you are in a different network namespace?
Author
Owner

@vn971 commented on GitHub (Jul 31, 2016):

@netblue30 well, why not do as you said: check x11 socket availability? It's not a strict rule (is it?), but it should work in most cases.

(Actually, I thought --audit works by analyzing the combined commands. But it seems it's a separate executable. Well, OK, that has some advantages, too.)

<!-- gh-comment-id:236436017 --> @vn971 commented on GitHub (Jul 31, 2016): @netblue30 well, why not do as you said: check x11 socket availability? It's not a strict rule (is it?), but it should work in most cases. (Actually, I thought `--audit` works by analyzing the combined commands. But it seems it's a separate executable. Well, OK, that has some advantages, too.)
Author
Owner

@netblue30 commented on GitHub (Aug 1, 2016):

I made it a separate program so you can switch in your own test program (--audit=program_name)

<!-- gh-comment-id:236560679 --> @netblue30 commented on GitHub (Aug 1, 2016): I made it a separate program so you can switch in your own test program (--audit=program_name)
Author
Owner

@netblue30 commented on GitHub (Aug 11, 2016):

Fixed:

$ firejail --x11 --audit xterm
Error: auditing x11 sandboxes is not supported
<!-- gh-comment-id:239284648 --> @netblue30 commented on GitHub (Aug 11, 2016): Fixed: ``` $ firejail --x11 --audit xterm Error: auditing x11 sandboxes is not supported ```
Author
Owner

@vn971 commented on GitHub (Aug 12, 2016):

@netblue30 eh, I wouldn't mind auditing an X11 app.. Well anyway, if that's the easiest approach, ok.

<!-- gh-comment-id:239407510 --> @vn971 commented on GitHub (Aug 12, 2016): @netblue30 eh, I wouldn't mind auditing an X11 app.. Well anyway, if that's the easiest approach, ok.
Author
Owner

@netblue30 commented on GitHub (Aug 12, 2016):

@manevich just put a fix in, auditing x11 sandboxes is supported in this moment!

<!-- gh-comment-id:239465373 --> @netblue30 commented on GitHub (Aug 12, 2016): @manevich just put a fix in, auditing x11 sandboxes is supported in this moment!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#457
No description provided.