[PR #2803] [MERGED] Streamline redirect profiles (follow-up) #4536

New issue

Closed

opened 2026-05-05 10:21:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:21:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2803
Author: @ghost
Created: 6/27/2019
Status: ✅ Merged
Merged: 6/27/2019
Merged by: @undefined

Base: master ← Head: redirect

📝 Commits (10+)

9801439 Streamline redirect profiles (2)
8711544 Streamline redirect profiles (2)
63406d3 Streamline redirect profiles (2)
cf7f647 Streamline redirect profiles (2)
bb4dbcb Streamline redirect profiles (2)
44f2965 Streamline redirect profiles (2)
197f40b Streamline redirect profiles (2)
c11b0ed Streamline redirect profiles (2)
4e4b09f Streamline redirect profiles (3)
c063808 Streamline redirect profiles (3)

📊 Changes

13 files changed (+16 additions, -17 deletions)

View changed files

📝 etc/Discord.profile (+1 -2)
📝 etc/DiscordCanary.profile (+1 -2)
📝 etc/atom-beta.profile (+5 -1)
📝 etc/autokey-gtk.profile (+1 -1)
📝 etc/autokey-qt.profile (+1 -1)
📝 etc/autokey-run.profile (+1 -1)
📝 etc/autokey-shell.profile (+1 -1)
📝 etc/chromium-common.profile (+1 -1)
📝 etc/cryptocat.profile (+0 -1)
📝 etc/discord-canary.profile (+1 -2)
📝 etc/discord-common.profile (+1 -1)
📝 etc/discord.profile (+1 -2)
📝 etc/firefox-common.profile (+1 -1)

📄 Description

I missed these in https://github.com/netblue30/firejail/pull/2802. Thanks at @rusty-snake for nudging me about this.

@rusty-snake I didn't fully understand your message in https://github.com/netblue30/firejail/pull/2802. GH hides something that I can read in the email version:

Great, still need streamlining:

atom-beta.profile

cryptocat.profile

cyberfox.profile

discord-canary.profile

DiscordCanary.profile

discord.profile

Discord.profile

@@ -16,6 +16,5 @@ whitelist ${HOME}/.mozilla
# private-etc must first be enabled in firefox-common.profile

include globals.local

If this relates to cyberfox.profile: that redirects to firefox-common.profile, which does not include globals.local (cfr. the comment inside). So I didn't need to touch cyberfox.profile. But you might have been referring to something else. If so, would you be so kind to reformulate what I've missed please?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2803 **Author:** [@ghost](https://github.com/ghost) **Created:** 6/27/2019 **Status:** ✅ Merged **Merged:** 6/27/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `redirect` --- ### 📝 Commits (10+) - [`9801439`](https://github.com/netblue30/firejail/commit/980143992cc2cc715cf97af3c8ca5e785a91bbd0) Streamline redirect profiles (2) - [`8711544`](https://github.com/netblue30/firejail/commit/8711544e37ee19cb43f081edc3a18c00696a711c) Streamline redirect profiles (2) - [`63406d3`](https://github.com/netblue30/firejail/commit/63406d365fcaf2416961b1e28f84c212151965a5) Streamline redirect profiles (2) - [`cf7f647`](https://github.com/netblue30/firejail/commit/cf7f64756f7651ad19fc6758e34513bb2bfe83f3) Streamline redirect profiles (2) - [`bb4dbcb`](https://github.com/netblue30/firejail/commit/bb4dbcb7d7e2673b699d413420bf42d75eda725f) Streamline redirect profiles (2) - [`44f2965`](https://github.com/netblue30/firejail/commit/44f2965aada69e4850213e5295d393d2cc886944) Streamline redirect profiles (2) - [`197f40b`](https://github.com/netblue30/firejail/commit/197f40b93c58c021dc8e80f3b4c641a280ed61e9) Streamline redirect profiles (2) - [`c11b0ed`](https://github.com/netblue30/firejail/commit/c11b0ed7af2407c42f665d7c970ca334755cc3bf) Streamline redirect profiles (2) - [`4e4b09f`](https://github.com/netblue30/firejail/commit/4e4b09feab2b72a9d5a79c55096836e45e8028f8) Streamline redirect profiles (3) - [`c063808`](https://github.com/netblue30/firejail/commit/c063808225d13f6c3f34eb22f7b26fff7c4ddd25) Streamline redirect profiles (3) ### 📊 Changes **13 files changed** (+16 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `etc/Discord.profile` (+1 -2) 📝 `etc/DiscordCanary.profile` (+1 -2) 📝 `etc/atom-beta.profile` (+5 -1) 📝 `etc/autokey-gtk.profile` (+1 -1) 📝 `etc/autokey-qt.profile` (+1 -1) 📝 `etc/autokey-run.profile` (+1 -1) 📝 `etc/autokey-shell.profile` (+1 -1) 📝 `etc/chromium-common.profile` (+1 -1) 📝 `etc/cryptocat.profile` (+0 -1) 📝 `etc/discord-canary.profile` (+1 -2) 📝 `etc/discord-common.profile` (+1 -1) 📝 `etc/discord.profile` (+1 -2) 📝 `etc/firefox-common.profile` (+1 -1) </details> ### 📄 Description I missed these in https://github.com/netblue30/firejail/pull/2802. Thanks at @rusty-snake for nudging me about this. @rusty-snake I didn't fully understand your message in https://github.com/netblue30/firejail/pull/2802. GH hides something that I can read in the email version: > Great, still need streamlining: > * atom-beta.profile > * cryptocat.profile > * cyberfox.profile > * discord-canary.profile > * DiscordCanary.profile > * discord.profile > * Discord.profile > > > > @@ -16,6 +16,5 @@ whitelist ${HOME}/.mozilla > \# private-etc must first be enabled in firefox-common.profile > > `include globals.local` If this relates to cyberfox.profile: that redirects to firefox-common.profile, which does not include globals.local (cfr. the comment inside). So I didn't need to touch cyberfox.profile. But you might have been referring to something else. If so, would you be so kind to reformulate what I've missed please? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:21:55 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4536

No description provided.

Rows
Columns