[PR #2694] [MERGED] Propagate --quiet to children Firejail'ed processes #4487

New issue

Closed

opened 2026-05-05 10:21:03 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:21:03 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2694
Author: @laomaiweng
Created: 5/13/2019
Status: ✅ Merged
Merged: 5/17/2019
Merged by: @netblue30

Base: master ← Head: propagate-quiet

📝 Commits (2)

f1207e7 Propagate --quiet to children Firejail'ed processes
ce3ff97 Move export of FIREJAIL_QUIET to env_defaults()

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 src/firejail/env.c (+5 -0)
📝 src/firejail/main.c (+2 -1)

📄 Description

Some Firejailed programs end up calling other programs for which a symlink to Firejail is also set up. When the child Firejailed process detects this, it prints on stderr a message along the lines of:

Warning: an existing sandbox was detected. /usr/bin/foobar will run without any additional sandboxing features

This breaks the behavior of some programs, which actually capture the standard error of their child process and don't expect to see Firejail output there. Examples include:

Github's hub: breaks when resolving git aliases
tpope's vim-fugitive: breaks the fugitive:// URLs built to view e.g. a commit from a blame window

Using --quiet (or quiet in the profile) for either the parent Firejailed process or its child does not fix the issue: --quiet is not propagated from a parent Firejailed process to its children, nor is any profile taken into account when Firejail detects it is running inside another Firejail process and prints the above warning.

This PR attempts to remedy this by having Firejail export the environment variable FIREJAIL_QUIET (when running with --quiet or quiet in the profile), so that any children Firejailed process takes notice and becomes quiet too.

Please feel free to discuss alternative solutions to this issue! :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2694 **Author:** [@laomaiweng](https://github.com/laomaiweng) **Created:** 5/13/2019 **Status:** ✅ Merged **Merged:** 5/17/2019 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `propagate-quiet` --- ### 📝 Commits (2) - [`f1207e7`](https://github.com/netblue30/firejail/commit/f1207e70c4703c5ff2c2f4b8a7506860f611c633) Propagate --quiet to children Firejail'ed processes - [`ce3ff97`](https://github.com/netblue30/firejail/commit/ce3ff9711e7cb6d966ce07714c5cd7ac331f7937) Move export of FIREJAIL_QUIET to env_defaults() ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/env.c` (+5 -0) 📝 `src/firejail/main.c` (+2 -1) </details> ### 📄 Description Some Firejailed programs end up calling other programs for which a symlink to Firejail is also set up. When the child Firejailed process detects this, it prints on `stderr` a message along the lines of: Warning: an existing sandbox was detected. /usr/bin/foobar will run without any additional sandboxing features This breaks the behavior of some programs, which actually capture the standard error of their child process and don't expect to see Firejail output there. Examples include: * Github's [hub](https://github.com/github/hub): breaks when resolving `git` aliases * tpope's [vim-fugitive](https://github.com/tpope/vim-fugitive): breaks the `fugitive://` URLs built to view e.g. a commit from a blame window Using `--quiet` (or `quiet` in the profile) for either the parent Firejailed process or its child does not fix the issue: `--quiet` is not propagated from a parent Firejailed process to its children, nor is any profile taken into account when Firejail detects it is running inside another Firejail process and prints the above warning. This PR attempts to remedy this by having Firejail export the environment variable `FIREJAIL_QUIET` (when running with `--quiet` or `quiet` in the profile), so that any children Firejailed process takes notice and becomes quiet too. Please feel free to discuss alternative solutions to this issue! :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:21:03 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:33:31 -06:00

[PR #4487] [MERGED] .git-blame-ignore-revs: add revert of allow/deny move #5168

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4487

No description provided.

Rows
Columns