[PR #2688] [MERGED] nodbus enhancements #4485

New issue

Closed

opened 2026-05-05 10:20:59 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:20:59 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2688
Author: @laomaiweng
Created: 5/10/2019
Status: ✅ Merged
Merged: 5/17/2019
Merged by: @netblue30

Base: master ← Head: nodbus-enhancements

📝 Commits (3)

fc309e9 Blacklist ~/.dbus with nodbus
6fad6fc Fix overridden DBUS_SESSION_BUS_ADDRESS with nodbus
0347e4d Merge branch 'master' into nodbus-enhancements

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 src/firejail/dbus.c (+9 -1)

📄 Description

Hi,

This PR adds/changes the following behaviors of nodbus:

blacklist ~/.dbus by default
fix the overridden value of DBUS_SESSION_BUS_ADDRESS

~/.dbus is created by dbus-launch and contains an environment file that can be sourced by the shell. It sets the values of DBUS_SESSION_BUS_ADDRESS and other DBus-related envvars, so that processes spawned by the shell can communicate with the session bus. Blacklisting it removes one way for firejailed programs to find out about the real address of the session bus (though other ways sadly still remain).

As for the overridden value of DBUS_SESSION_BUS_ADDRESS, it contained DBUS_SESSION_BUS_ADDRESS= itself at the start, which seemed like a mistake.

Hope this is helpful!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2688 **Author:** [@laomaiweng](https://github.com/laomaiweng) **Created:** 5/10/2019 **Status:** ✅ Merged **Merged:** 5/17/2019 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `nodbus-enhancements` --- ### 📝 Commits (3) - [`fc309e9`](https://github.com/netblue30/firejail/commit/fc309e9bf1a31730fcc3e97f1a70200b60d95b72) Blacklist ~/.dbus with nodbus - [`6fad6fc`](https://github.com/netblue30/firejail/commit/6fad6fce947e93c43d807f82b5d7265da83ea74d) Fix overridden DBUS_SESSION_BUS_ADDRESS with nodbus - [`0347e4d`](https://github.com/netblue30/firejail/commit/0347e4d7efd4b0331bcb6ffef0f4e6f0af8af7e2) Merge branch 'master' into nodbus-enhancements ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/dbus.c` (+9 -1) </details> ### 📄 Description Hi, This PR adds/changes the following behaviors of `nodbus`: * blacklist `~/.dbus` by default * fix the overridden value of `DBUS_SESSION_BUS_ADDRESS` `~/.dbus` is created by `dbus-launch` and contains an environment file that can be sourced by the shell. It sets the values of `DBUS_SESSION_BUS_ADDRESS` and other DBus-related envvars, so that processes spawned by the shell can communicate with the session bus. Blacklisting it removes one way for firejailed programs to find out about the real address of the session bus (though other ways sadly still remain). As for the overridden value of `DBUS_SESSION_BUS_ADDRESS`, it contained `DBUS_SESSION_BUS_ADDRESS=` itself at the start, which seemed like a mistake. Hope this is helpful! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:20:59 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:33:27 -06:00

[PR #4485] [MERGED] updating youtube-viewers-common.profile #5166

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4485

No description provided.

Rows
Columns