[PR #2327] [MERGED] Correctly set address length in arp frames #4266

Closed
opened 2026-05-05 10:16:50 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2327
Author: @NickMolloy
Created: 1/2/2019
Status: Merged
Merged: 1/7/2019
Merged by: @netblue30

Base: masterHead: fix-addr-length


📝 Commits (1)

  • 81f4159 Correctly set address length in arp frames

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/firejail/arp.c (+2 -2)
📝 src/fnet/arp.c (+1 -1)

📄 Description

Kernel commit 99137b7 introduced an additional check of the address
length. This exposed a bug in the arp code where the address length was
being set incorrectly.
Now the length is set from the ETH_ALEN constant declared in
linux/if_ether.h.

This fixes #2314


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2327 **Author:** [@NickMolloy](https://github.com/NickMolloy) **Created:** 1/2/2019 **Status:** ✅ Merged **Merged:** 1/7/2019 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-addr-length` --- ### 📝 Commits (1) - [`81f4159`](https://github.com/netblue30/firejail/commit/81f4159fa88c8d34b291fe8708595d50ac68464c) Correctly set address length in arp frames ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/arp.c` (+2 -2) 📝 `src/fnet/arp.c` (+1 -1) </details> ### 📄 Description Kernel commit [99137b7](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99137b7888f4058087895d035d81c6b2d31015c5) introduced an additional check of the address length. This exposed a bug in the arp code where the address length was being set incorrectly. Now the length is set from the `ETH_ALEN` constant declared in `linux/if_ether.h`. This fixes #2314 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:16:50 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4266
No description provided.