[PR #2253] [MERGED] Have appimage handling be the same with or with out special -- argument. #4239

New issue

Closed

opened 2026-05-05 10:16:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:16:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2253
Author: @crass
Created: 11/8/2018
Status: ✅ Merged
Merged: 11/9/2018
Merged by: @netblue30

Base: master ← Head: fix-appimage-double-dash-handling

📝 Commits (1)

cad5333 Have appimage handling be the same with or with out special -- argument.

📊 Changes

1 file changed (+9 additions, -12 deletions)

View changed files

📝 src/firejail/main.c (+9 -12)

📄 Description

When not using -- on the command line along with --appimage, extract_command_name is not run and instead cfg.command_name is set and arg_shell_none is set to 0. This is what one wants when running appimages where the AppRun is a shell script (eg. digikam). However, this logic is not consistently applied when processing the -- special option.

The effect of this is that using -- with the digikam appimage and digikam profile fails to run digikam because the digikam profile sets shell none. This can be overcome by adding ignore=shell, but that shouldn't be necessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2253 **Author:** [@crass](https://github.com/crass) **Created:** 11/8/2018 **Status:** ✅ Merged **Merged:** 11/9/2018 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-appimage-double-dash-handling` --- ### 📝 Commits (1) - [`cad5333`](https://github.com/netblue30/firejail/commit/cad533365168c418fbf4ac0984f7fa5893ef07e2) Have appimage handling be the same with or with out special -- argument. ### 📊 Changes **1 file changed** (+9 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+9 -12) </details> ### 📄 Description When not using `--` on the command line along with `--appimage`, `extract_command_name` is not run and instead `cfg.command_name` is set and `arg_shell_none` is set to `0`. This is what one wants when running appimages where the `AppRun` is a shell script (eg. digikam). However, this logic is not consistently applied when processing the `--` special option. The effect of this is that using `--` with the digikam appimage and digikam profile fails to run digikam because the digikam profile sets `shell none`. This can be overcome by adding `ignore=shell`, but that shouldn't be necessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>