[PR #2141] [MERGED] Update appimage size calculation to newest code from libappimage. #4183

New issue

Closed

opened 2026-05-05 10:15:17 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:15:17 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2141
Author: @crass
Created: 10/6/2018
Status: ✅ Merged
Merged: 10/6/2018
Merged by: @netblue30

Base: master ← Head: fix-appimage-hdr-calc

📝 Commits (1)

fb8db88 Update appimage size calculation to newest code from libappimage.

📊 Changes

1 file changed (+27 additions, -7 deletions)

View changed files

📝 src/firejail/appimage_size.c (+27 -7)

📄 Description

These changes specifically allow the 61.0.1.glibc2.7 version of the firefox appimage to run successfully. Currently firejail errors out printing that the ELF size is 0 and its an appimage type 1, both of which are incorrect. I've updated for both 32 and 64-bit appimages, but I've only tested with this 64-bit one (which loads the appimage successfully, but I can't get a successful connection). But I believe my copy/paste skills are up to par.

This can be tested with the appimage here:
https://bintray.com/probono/AppImages/Firefox/61.0.1.glibc2.7#files

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2141 **Author:** [@crass](https://github.com/crass) **Created:** 10/6/2018 **Status:** ✅ Merged **Merged:** 10/6/2018 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-appimage-hdr-calc` --- ### 📝 Commits (1) - [`fb8db88`](https://github.com/netblue30/firejail/commit/fb8db88d4764ff016e1bb07908165cb782469cb7) Update appimage size calculation to newest code from libappimage. ### 📊 Changes **1 file changed** (+27 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/appimage_size.c` (+27 -7) </details> ### 📄 Description These changes specifically allow the `61.0.1.glibc2.7` version of the firefox appimage to run successfully. Currently firejail errors out printing that the ELF size is 0 and its an appimage type 1, both of which are incorrect. I've updated for both 32 and 64-bit appimages, but I've only tested with this 64-bit one (which loads the appimage successfully, but I can't get a successful connection). But I believe my copy/paste skills are up to par. This can be tested with the appimage here: https://bintray.com/probono/AppImages/Firefox/61.0.1.glibc2.7#files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:15:17 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4183

No description provided.

Rows
Columns