[PR #2060] [MERGED] WIP: Add new disable-xdg.inc #4163

New issue

Closed

opened 2026-05-05 10:14:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:14:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/2060
Author: @SkewedZeppelin
Created: 7/24/2018
Status: ✅ Merged
Merged: 7/24/2018
Merged by: @netblue30

Base: master ← Head: disable-xdg

📝 Commits (2)

6de9a77 Add disable-xdg.inc
94a0123 Initial adding of disable-xdg.inc

📊 Changes

18 files changed (+36 additions, -1 deletions)

View changed files

📝 etc/2048-qt.profile (+5 -0)
📝 etc/Fritzing.profile (+2 -0)
📝 etc/android-studio.profile (+2 -0)
📝 etc/aosp.profile (+1 -0)
📝 etc/apktool.profile (+1 -0)
📝 etc/arch-audit.profile (+1 -0)
📝 etc/archaudit-report.profile (+1 -0)
➕ etc/disable-xdg.inc (+10 -0)
📝 etc/gnome-books.profile (+2 -0)
📝 etc/gnome-calculator.profile (+1 -0)
📝 etc/gnome-chess.profile (+1 -0)
📝 etc/gnome-clocks.profile (+1 -0)
📝 etc/gnome-contacts.profile (+2 -1)
📝 etc/gnome-documents.profile (+2 -0)
📝 etc/gnome-font-viewer.profile (+1 -0)
📝 etc/gnome-logs.profile (+1 -0)
📝 etc/gnome-maps.profile (+1 -0)
📝 etc/gnome-weather.profile (+1 -0)

📄 Description

Now that @chiraag-nataraj added support for more XDG user dirs in fff306c991, we can blacklist these in many profiles that don't utilize whitelist.

I created a disable-xdg.inc. Downloads and Desktop are commented as they are usually a catch-all for most people.

And I included it in a small amount of profiles identified using the following command:

grep "disable-xdg" -RL $(grep 'whitelist \$' -RL $(grep "redirect" . -RiL))

there are still ~270 remaining, and strong discretion is needed, so I figured I'd get some discussion going before I went at it. Feel free to push to the branch at will.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/2060 **Author:** [@SkewedZeppelin](https://github.com/SkewedZeppelin) **Created:** 7/24/2018 **Status:** ✅ Merged **Merged:** 7/24/2018 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `disable-xdg` --- ### 📝 Commits (2) - [`6de9a77`](https://github.com/netblue30/firejail/commit/6de9a7700ef0f30fcbc3c6c6764ad8922b22b50f) Add disable-xdg.inc - [`94a0123`](https://github.com/netblue30/firejail/commit/94a0123568785386f907cd0fef7d5fc80ffb7d75) Initial adding of disable-xdg.inc ### 📊 Changes **18 files changed** (+36 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `etc/2048-qt.profile` (+5 -0) 📝 `etc/Fritzing.profile` (+2 -0) 📝 `etc/android-studio.profile` (+2 -0) 📝 `etc/aosp.profile` (+1 -0) 📝 `etc/apktool.profile` (+1 -0) 📝 `etc/arch-audit.profile` (+1 -0) 📝 `etc/archaudit-report.profile` (+1 -0) ➕ `etc/disable-xdg.inc` (+10 -0) 📝 `etc/gnome-books.profile` (+2 -0) 📝 `etc/gnome-calculator.profile` (+1 -0) 📝 `etc/gnome-chess.profile` (+1 -0) 📝 `etc/gnome-clocks.profile` (+1 -0) 📝 `etc/gnome-contacts.profile` (+2 -1) 📝 `etc/gnome-documents.profile` (+2 -0) 📝 `etc/gnome-font-viewer.profile` (+1 -0) 📝 `etc/gnome-logs.profile` (+1 -0) 📝 `etc/gnome-maps.profile` (+1 -0) 📝 `etc/gnome-weather.profile` (+1 -0) </details> ### 📄 Description Now that @chiraag-nataraj added support for more XDG user dirs in fff306c991ff1f33ccb56313e4c166a169555656, we can blacklist these in many profiles that don't utilize whitelist. I created a disable-xdg.inc. Downloads and Desktop are commented as they are usually a catch-all for most people. And I included it in a small amount of profiles identified using the following command: ``` grep "disable-xdg" -RL $(grep 'whitelist \$' -RL $(grep "redirect" . -RiL)) ``` there are still ~270 remaining, and strong discretion is needed, so I figured I'd get some discussion going before I went at it. Feel free to push to the branch at will. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:14:56 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4163

No description provided.

Rows
Columns