[PR #1906] [MERGED] Re-enable join-or-start #4121

New issue

Closed

opened 2026-05-05 10:14:07 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:14:07 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/1906
Author: @aerusso
Created: 4/23/2018
Status: ✅ Merged
Merged: 4/23/2018
Merged by: @netblue30

Base: master ← Head: pulls/join-or-start

📝 Commits (2)

926e8e9 Implemenent require_pid
01129ad Re-enable join-or-start

📊 Changes

1 file changed (+42 additions, -34 deletions)

View changed files

📝 src/firejail/main.c (+42 -34)

📄 Description

The join-or-start option has been broken since 3374e24eb, when that code got out of sync with the new read_pid approach to handling sandbox names.

This pair of patches

Separates the validation of the existence of a named sandbox out of read_pid into require_pid
Updates all old read_pid calls to the new require_pid function.
Re-enables the join-or-start option, using the non-validating read_pid function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/1906 **Author:** [@aerusso](https://github.com/aerusso) **Created:** 4/23/2018 **Status:** ✅ Merged **Merged:** 4/23/2018 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `pulls/join-or-start` --- ### 📝 Commits (2) - [`926e8e9`](https://github.com/netblue30/firejail/commit/926e8e954cce812ea0218acaef421a9e29c65e0d) Implemenent require_pid - [`01129ad`](https://github.com/netblue30/firejail/commit/01129ad401b7020b6d7b5270e450729c36f4444e) Re-enable join-or-start ### 📊 Changes **1 file changed** (+42 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+42 -34) </details> ### 📄 Description The `join-or-start` option has been broken since 3374e24eb, when that code got out of sync with the new `read_pid` approach to handling sandbox names. This pair of patches 1. Separates the validation of the existence of a named sandbox out of `read_pid` into `require_pid` 2. Updates all old `read_pid` calls to the new `require_pid` function. 3. Re-enables the `join-or-start` option, using the non-validating `read_pid` function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:14:07 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:31:06 -06:00

[PR #4121] [MERGED] fix private-lib in clawsker.profile #5036

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4121

No description provided.

Rows
Columns