mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #1891] [MERGED] Fix firefox common addons #4114
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#4114
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/1891
Author: @ghost
Created: 4/16/2018
Status: ✅ Merged
Merged: 4/17/2018
Merged by: @SkewedZeppelin
Base:
master← Head:firefox📝 Commits (2)
92f21eeFix firefox common addons0e8d52freorganize previous commit📊 Changes
1 file changed (+11 additions, -2 deletions)
View changed files
📝
etc/firefox-common-addons.inc(+11 -2)📄 Description
GNOME Shell integrationrelies on dbus and python 3. When users opt to include firefox-common-addons.inc (in firefox-common.profile), chrome-gnome-shell is currently broken. Opening its preferences shows ... 'Although GNOME Shell integration extension is running, native host connector is not detected. Refer to documentation for instructions about installing connector.'. Easily fixed by addingignore nodbusandallowing python 3insidefirefox-common-addons.inc, so users that don't include that file (the default) get an unchanged firejail experience.NOTE: I suspect that chromium-based browsers would need a similar profile change when using GNOME Shell integration , but I neither use nor know these well enough to propose a PR.
Additionally, users using the
Flashplugin could benefit from addingadobetoprivate-etc. I left that commented, to stay in sync with what's in firefox-common.profile.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.