mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #1837] [MERGED] WIP: Blacklist common programming interpreters. #4085
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#4085
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/1837
Author: @Fred-Barclay
Created: 3/26/2018
Status: ✅ Merged
Merged: 4/2/2018
Merged by: @Fred-Barclay
Base:
master← Head:disable-interpreters📝 Commits (10+)
b78e2d0more restrictive private-lib8fbbb5aUse path variable instead of full path when blacklisting devel tools.c4384a7Part 1: blacklist python, perl, ruby, etc in disable-interpreters.inc9e238e0Part 2: allow access to java as neededcfa25b1Typo: missing blacklist60836f9Part 3: allow perl access as neededbe80d53typo6f3cb65Merge pull request #1831 from glitsj16/eog3c2f0c8Add xreader thumbnailer and previewer profiles2e0730cAdd xplayer audio-preview and thumbnailer profiles📊 Changes
380 files changed (+1301 additions, -758 deletions)
View changed files
📝
.gitignore(+2 -0)📝
Makefile.in(+3 -1)📝
README.md(+18 -4)📝
RELNOTES(+4 -4)📝
configure(+21 -4)📝
configure.ac(+13 -3)📝
etc/0ad.profile(+2 -0)📝
etc/2048-qt.profile(+1 -0)📝
etc/7z.profile(+1 -1)📝
etc/Cryptocat.profile(+1 -0)📝
etc/Fritzing.profile(+1 -0)📝
etc/Mathematica.profile(+1 -0)📝
etc/Thunar.profile(+1 -0)📝
etc/Viber.profile(+1 -0)📝
etc/akonadi_control.profile(+9 -4)📝
etc/akregator.profile(+1 -0)📝
etc/amarok.profile(+1 -0)📝
etc/amule.profile(+1 -0)📝
etc/apktool.profile(+1 -2)📝
etc/arch-audit.profile(+1 -0)...and 80 more files
📄 Description
See discussion in #1823
This is like disable-devel, but for python, perl, etc.
These profiles still need python access:
nautilus
pithos
qutebrowser
sdat2img
deluge
meld
catfish
gajim --- Python 2.7
xpra
display
gnome-music
macrofusion
caja
xchat
nemo
torbrowser-launcher
filezilla
hexchat
arm
xed uses python plugins, but private-bin already excludes python.
These still need java access:
pdfsam
dex2jar
imagej
These still need perl access:
playonlinux
exiftool
xchat needs perl and python (at least) so I didn't add disable-interpreters
I haven't tested all of the new profiles, so there might be some (a lot?) of breaks, most likely from python blacklisting. I suspect there may still be some issues in mate, cinnamon, and gnome profiles. I also relied a lot on the pre-existing private-bin filters to tell if a program needed python or not, so if a profiledoesn't have a private-bin filter and needs python, this will break it.
I'm most confident about the profiles that already had private-bin without python, or memory-deny-write-executable, since I seem to recall this line breaking a lot of python-based programs. dnscrypt-proxy may be an exception.
If we're close to releasing 0.9.54 it might be better to wait until after the release to merge so we can have more testing time. @netblue30 thoughts?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.