mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #1775] [MERGED] Apparmor: don't duplicate userspace /run/user restrictions #4067
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#4067
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/1775
Author: @Vincent43
Created: 2/14/2018
Status: ✅ Merged
Merged: 2/19/2018
Merged by: @Vincent43
Base:
master← Head:patch-1📝 Commits (1)
cc1c524Apparmor: don't duplicate userspace /run/user restrictions📊 Changes
1 file changed (+6 additions, -14 deletions)
View changed files
📝
etc/firejail-default(+6 -14)📄 Description
Currently userspace firejail do blacklist approach to
/run/user/directory. By default it blacklists/run/user/**/systemdand/run/user/**/gnupg. Additional restrictions can be enabled in profiles like blacklisting/run/user/**/bus, etc. The blacklist can be extended or degraded by profile which allows for fine grained hardening.In apparmor we do whitelist approach instead. It means we have to explicitly enable access to every file which firejail already allow access. This duplicates functionality and amount of work to do. Moreover we end up with same list of allowed files as every one of them is used by some app and apparmor profile is global. It's even worse as firejail blacklist can be disabled with
writable-run-usercommand which means we have to whitelist literally everything under/run/user/to not cause breakages when using apparmor.The solution for all above is to leave handling of
/run/userto userspace firejail which is better tool to do this. In apparmor we should only handle things which firejail can't do on its own.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.