mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #1662] [MERGED] In Testing: (Re)add disable-mnt to common browser profiles. #4039
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#4039
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/1662
Author: @Fred-Barclay
Created: 11/29/2017
Status: ✅ Merged
Merged: 11/30/2017
Merged by: @Fred-Barclay
Base:
master← Head:enable-mnt_browsers📝 Commits (2)
36d3043(Re)add disable-mnt to common browser profiles.288d9a8Add disable-mnt to surf profile📊 Changes
18 files changed (+26 additions, -2 deletions)
View changed files
📝
etc/brave.profile(+1 -1)📝
etc/chromium.profile(+1 -0)📝
etc/conkeror.profile(+2 -0)📝
etc/cyberfox.profile(+2 -1)📝
etc/flashpeak-slimjet.profile(+2 -0)📝
etc/google-chrome.profile(+1 -0)📝
etc/icecat.profile(+1 -0)📝
etc/midori.profile(+2 -0)📝
etc/netsurf.profile(+2 -0)📝
etc/opera-beta.profile(+2 -0)📝
etc/opera.profile(+2 -0)📝
etc/palemoon.profile(+2 -0)📝
etc/seamonkey.profile(+1 -0)📝
etc/start-tor-browser.profile(+1 -0)📝
etc/surf.profile(+1 -0)📝
etc/torbrowser-launcher.profile(+1 -0)📝
etc/vivaldi.profile(+1 -0)📝
etc/yandex-browser.profile(+1 -0)📄 Description
Let's don't merge this just yet.
This adds disable-mnt to most (all?) of our browser profiles as per the discussion in #1660, blocking access to mount points. This does mean some users (relatively few) will have some problems if their ${DOWNLOADS}, etc, are on external media, but I think it's an acceptable tradeoff for the increased sandbox tightness that will benefit the majority of users.
Thoughts/comments/suggestions/"we-shouldn't-do-this-because-xyz"? 😁
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.