[PR #1494] [MERGED] Allow private-bin parameters to be absolute paths #3992

Closed
opened 2026-05-05 10:11:47 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/1494
Author: @LaurentGH
Created: 8/24/2017
Status: Merged
Merged: 8/25/2017
Merged by: @netblue30

Base: masterHead: master


📝 Commits (1)

  • e1a2449 Allow private-bin parameters to be an absolute path

📊 Changes

1 file changed (+22 additions, -8 deletions)

View changed files

📝 src/firejail/fs_bin.c (+22 -8)

📄 Description

With Ubuntu 16.04, /usr/bin/which is a symlink to /bin/which. So, using "private-bin which" finds "which" in /usr/bin and adds the symlink to "which" in /bin mapped directory. The /bin directory thus contains a symlink named "which" pointing to "/bin/which" (itself). This creates a symlink loop, and does not work. In order to solve this, the full path can now be used, such as "private-bin /bin/which". This fixes #1133.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/1494 **Author:** [@LaurentGH](https://github.com/LaurentGH) **Created:** 8/24/2017 **Status:** ✅ Merged **Merged:** 8/25/2017 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e1a2449`](https://github.com/netblue30/firejail/commit/e1a24494343016d00100e5e8e7e8716ac77363f6) Allow private-bin parameters to be an absolute path ### 📊 Changes **1 file changed** (+22 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/fs_bin.c` (+22 -8) </details> ### 📄 Description With Ubuntu 16.04, /usr/bin/which is a symlink to /bin/which. So, using "private-bin which" finds "which" in /usr/bin and adds the symlink to "which" in /bin mapped directory. The /bin directory thus contains a symlink named "which" pointing to "/bin/which" (itself). This creates a symlink loop, and does not work. In order to solve this, the full path can now be used, such as "private-bin /bin/which". This fixes #1133. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:11:47 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3992
No description provided.