[PR #1409] [MERGED] Fix typo for fnet moveif invocation on 2nd interface. #3948

New issue

Closed

opened 2026-05-05 10:10:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:10:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/1409
Author: @caoliver
Created: 7/27/2017
Status: ✅ Merged
Merged: 7/27/2017
Merged by: @netblue30

Base: master ← Head: master

📝 Commits (1)

cb95fbc Fix typo for fnet moveif invocation on 2nd interface.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/firejail/network_main.c (+1 -1)

📄 Description

I noticed a fair bit of copy pasta here. While that may not necessarily be bad in itself, is there a reason where the duplication can be easily parameterized to avoid using C preprocessor macros with the ## operator to avoid this sort of typo?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/1409 **Author:** [@caoliver](https://github.com/caoliver) **Created:** 7/27/2017 **Status:** ✅ Merged **Merged:** 7/27/2017 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cb95fbc`](https://github.com/netblue30/firejail/commit/cb95fbc15e1326f619876347149aa8db82933e3d) Fix typo for fnet moveif invocation on 2nd interface. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/network_main.c` (+1 -1) </details> ### 📄 Description I noticed a fair bit of copy pasta here. While that may not necessarily be bad in itself, is there a reason where the duplication can be easily parameterized to avoid using C preprocessor macros with the ## operator to avoid this sort of typo? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:10:55 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3948

No description provided.

Rows
Columns