[PR #1307] [MERGED] minor bugfix: Correctly dereference "subdirname" variable #3916

New issue

Closed

opened 2026-05-05 10:10:17 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:10:17 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/1307
Author: @thomasjfox
Created: 5/23/2017
Status: ✅ Merged
Merged: 5/25/2017
Merged by: @reinerh

Base: master ← Head: fix-subdirname-dereference

📝 Commits (2)

4ec84fa minor bugfix: Correctly dereference "subdirname" variable
9215296 Fix another "subdirname" variable dereference issue

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 src/firejail/main.c (+1 -1)
📝 src/firejail/profile.c (+1 -1)

📄 Description

cppcheck reported:
[firejail/main.c:1335]: (warning) Char literal compared with pointer 'subdirname'. Did you intend to dereference it?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/1307 **Author:** [@thomasjfox](https://github.com/thomasjfox) **Created:** 5/23/2017 **Status:** ✅ Merged **Merged:** 5/25/2017 **Merged by:** [@reinerh](https://github.com/reinerh) **Base:** `master` ← **Head:** `fix-subdirname-dereference` --- ### 📝 Commits (2) - [`4ec84fa`](https://github.com/netblue30/firejail/commit/4ec84fa66436a6e64bf54edd98f80398e40765cb) minor bugfix: Correctly dereference "subdirname" variable - [`9215296`](https://github.com/netblue30/firejail/commit/9215296d34407e487187a0ef30bf623d2a417dc5) Fix another "subdirname" variable dereference issue ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+1 -1) 📝 `src/firejail/profile.c` (+1 -1) </details> ### 📄 Description cppcheck reported: [firejail/main.c:1335]: (warning) Char literal compared with pointer 'subdirname'. Did you intend to dereference it? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:10:17 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:29:27 -06:00

[PR #3916] [MERGED] Misc comment fixes #4943

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3916

No description provided.

Rows
Columns