[PR #1182] [MERGED] tidy up #3870

Closed
opened 2026-05-05 10:09:26 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/1182
Author: @SYN-cook
Created: 3/31/2017
Status: Merged
Merged: 3/31/2017
Merged by: @Fred-Barclay

Base: masterHead: patch-1


📝 Commits (7)

📊 Changes

7 files changed (+7 additions, -10 deletions)

View changed files

📝 etc/abrowser.profile (+0 -1)
📝 etc/cyberfox.profile (+0 -1)
📝 etc/disable-common.inc (+7 -4)
📝 etc/firefox.profile (+0 -1)
📝 etc/icecat.profile (+0 -1)
📝 etc/midori.profile (+0 -1)
📝 etc/seamonkey.profile (+0 -1)

📄 Description

  1. noblacklist ~/.lastpass is redundant code, because there is no include /etc/firejail/disable-passwdmgr.inc in these profiles...... and I myself introduced it! I can't recall the details of how this happened, but please let's get rid of it.
  2. minor reorganization in disable-common.inc

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/1182 **Author:** [@SYN-cook](https://github.com/SYN-cook) **Created:** 3/31/2017 **Status:** ✅ Merged **Merged:** 3/31/2017 **Merged by:** [@Fred-Barclay](https://github.com/Fred-Barclay) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (7) - [`a8953e9`](https://github.com/netblue30/firejail/commit/a8953e921501afd931dc13aeca7f85c5173d12a6) minor reorganization - [`bc97edb`](https://github.com/netblue30/firejail/commit/bc97edb9faa3727bbd831ca8d50be36a88e25219) tidy up - [`f78ff47`](https://github.com/netblue30/firejail/commit/f78ff4700713b047b28945fa71cfb103b81c68e6) tidy up - [`e731b4f`](https://github.com/netblue30/firejail/commit/e731b4f160340a1a44b3e8a9385672818d01d54f) tidy up - [`136f46f`](https://github.com/netblue30/firejail/commit/136f46f7c170b4d2d07ce9669adf8411aa2df865) tidy up - [`b89f496`](https://github.com/netblue30/firejail/commit/b89f496640318572e68fd8bbb37b777820cf6485) tidy up - [`52c8033`](https://github.com/netblue30/firejail/commit/52c80331ea8de14f97c8b6220986e7de6204b953) tidy up ### 📊 Changes **7 files changed** (+7 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `etc/abrowser.profile` (+0 -1) 📝 `etc/cyberfox.profile` (+0 -1) 📝 `etc/disable-common.inc` (+7 -4) 📝 `etc/firefox.profile` (+0 -1) 📝 `etc/icecat.profile` (+0 -1) 📝 `etc/midori.profile` (+0 -1) 📝 `etc/seamonkey.profile` (+0 -1) </details> ### 📄 Description 1. `noblacklist ~/.lastpass` is redundant code, because there is no `include /etc/firejail/disable-passwdmgr.inc` in these profiles...... and I myself introduced it! I can't recall the details of how this happened, but please let's get rid of it. 2. minor reorganization in disable-common.inc --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:09:26 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3870
No description provided.