[PR #1004] [MERGED] allow multiple private-argv #3818

New issue

Closed

opened 2026-05-05 10:08:30 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:08:30 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/1004
Author: @thewisenerd
Created: 12/24/2016
Status: ✅ Merged
Merged: 12/24/2016
Merged by: @netblue30

Base: master ← Head: patch-multiple-private-argv

📝 Commits (4)

93d9d7a argv: private-home: exit on invalid option
ee338c3 firejail: private-* : check, then assign.
ef75c0c firejail: profile: allow multiple private-* options
df38295 firejail: argv: allow multiple private-* options

📊 Changes

2 files changed (+62 additions, -14 deletions)

View changed files

📝 src/firejail/main.c (+33 -9)
📝 src/firejail/profile.c (+29 -5)

📄 Description

take an example of this test.profile.

private-home testA
private-home testB

# default profile
include /usr/local/etc/firejail/default.profile

running firejail --private --profile=test.profile copies only testB.
running firejail --private --profile=test.profile --private-home=testC copies only testC
running firejail --private --profile=test.profile --private-home=testC --private-home=testD copies only testD

after this patch:

running firejail --private --profile=test.profile copies testA and testB.
running firejail --private --profile=test.profile --private-home=testC copies testA, testB and testC
running firejail --private --profile=test.profile --private-home=testC --private-home=testD copies testA, testB, testC, and testD

same logic applies for nested include of other profile files.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/1004 **Author:** [@thewisenerd](https://github.com/thewisenerd) **Created:** 12/24/2016 **Status:** ✅ Merged **Merged:** 12/24/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `patch-multiple-private-argv` --- ### 📝 Commits (4) - [`93d9d7a`](https://github.com/netblue30/firejail/commit/93d9d7aece7f5951ccfd106cf5b94636074ece67) argv: private-home: exit on invalid option - [`ee338c3`](https://github.com/netblue30/firejail/commit/ee338c3757e3b02765689623a6e81ee8b6c55905) firejail: private-* : check, then assign. - [`ef75c0c`](https://github.com/netblue30/firejail/commit/ef75c0c22e35bc1cb5339519871de8e1dc4ed5c7) firejail: profile: allow multiple private-* options - [`df38295`](https://github.com/netblue30/firejail/commit/df38295faa992dbcb02b4f18dedbd60b770d4d22) firejail: argv: allow multiple private-* options ### 📊 Changes **2 files changed** (+62 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+33 -9) 📝 `src/firejail/profile.c` (+29 -5) </details> ### 📄 Description take an example of this ```test.profile```. ``` private-home testA private-home testB # default profile include /usr/local/etc/firejail/default.profile ``` - running ```firejail --private --profile=test.profile``` copies only ```testB```. - running ```firejail --private --profile=test.profile --private-home=testC``` copies only ```testC``` - running ```firejail --private --profile=test.profile --private-home=testC --private-home=testD``` copies only ```testD``` after this patch: - running ```firejail --private --profile=test.profile``` copies ```testA``` and ```testB```. - running ```firejail --private --profile=test.profile --private-home=testC``` copies ```testA```, ```testB``` and ```testC``` - running ```firejail --private --profile=test.profile --private-home=testC --private-home=testD``` copies ```testA```, ```testB```, ```testC```, and ```testD``` same logic applies for nested ```include``` of other profile files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:08:30 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:28:31 -06:00

[PR #3818] [MERGED] streamline comments in inc files #4892

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3818

No description provided.

Rows
Columns