[PR #991] [MERGED] appimage: pass commandline arguments #3815

New issue

Closed

opened 2026-05-05 10:08:25 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:08:25 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/991
Author: @thewisenerd
Created: 12/18/2016
Status: ✅ Merged
Merged: 12/19/2016
Merged by: @netblue30

Base: master ← Head: master

📝 Commits (1)

77783f1 appimage: pass commandline arguments

📊 Changes

3 files changed (+46 additions, -1 deletions)

View changed files

📝 src/firejail/cmdline.c (+44 -0)
📝 src/firejail/firejail.h (+1 -0)
📝 src/firejail/main.c (+1 -1)

📄 Description

commandline arguments are not being passed to appimage,
which hinders some functionality. This adds the function
build_appimage_cmdline based on build_cmdline which
works by calling quote_cmdline with passed argv, and
then replaces initial argument with AppRun path generated
in appimage_set.

TODO: deal with extra memory allocation. The 'quoted'
length of the first '*.AppImage' argument may or may not
be greater than the 'quoted' AppRun path.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/991 **Author:** [@thewisenerd](https://github.com/thewisenerd) **Created:** 12/18/2016 **Status:** ✅ Merged **Merged:** 12/19/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`77783f1`](https://github.com/netblue30/firejail/commit/77783f1ec2cd91891161616c9cd0abaf60897cc0) appimage: pass commandline arguments ### 📊 Changes **3 files changed** (+46 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/cmdline.c` (+44 -0) 📝 `src/firejail/firejail.h` (+1 -0) 📝 `src/firejail/main.c` (+1 -1) </details> ### 📄 Description commandline arguments are not being passed to appimage, which hinders some functionality. This adds the function build_appimage_cmdline based on build_cmdline which works by calling quote_cmdline with passed argv, and then replaces initial argument with AppRun path generated in appimage_set. TODO: deal with extra memory allocation. The 'quoted' length of the first '*.AppImage' argument may or may not be greater than the 'quoted' AppRun path. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:08:25 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3815

No description provided.

Rows
Columns