[PR #734] [MERGED] join fixes #3736

New issue

Closed

opened 2026-05-05 10:06:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:06:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/734
Author: @manevich
Created: 8/20/2016
Status: ✅ Merged
Merged: 8/20/2016
Merged by: @netblue30

Base: master ← Head: audit

📝 Commits (2)

1c030e8 audit for existing sandbox
5b9ac21 set caps filter when joining

📊 Changes

1 file changed (+25 additions, -67 deletions)

View changed files

📝 src/firejail/join.c (+25 -67)

📄 Description

simplify join function by reusing start_application. Honor --audit option on joining as result.
fix caps filter setting being affected by setting user namespace, same way as in https://github.com/netblue30/firejail/blob/master/src/firejail/sandbox.c#L789. Don't know if setting caps after setting user namespace is enough, or one on line 286 is required too. I left if as is currently.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/734 **Author:** [@manevich](https://github.com/manevich) **Created:** 8/20/2016 **Status:** ✅ Merged **Merged:** 8/20/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `audit` --- ### 📝 Commits (2) - [`1c030e8`](https://github.com/netblue30/firejail/commit/1c030e81348376f64288ad70f88deb7bfb6cff08) audit for existing sandbox - [`5b9ac21`](https://github.com/netblue30/firejail/commit/5b9ac21d4e98fd05549051f8dc9f92f9f0159ce3) set caps filter when joining ### 📊 Changes **1 file changed** (+25 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/join.c` (+25 -67) </details> ### 📄 Description - simplify `join` function by reusing `start_application`. Honor `--audit` option on joining as result. - fix caps filter setting being affected by setting user namespace, same way as in https://github.com/netblue30/firejail/blob/master/src/firejail/sandbox.c#L789. Don't know if setting caps after setting user namespace is enough, or one on line 286 is required too. I left if as is currently. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:06:56 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3736

No description provided.

Rows
Columns