[PR #729] [MERGED] run_no_sandbox fix #3735

New issue

Closed

opened 2026-05-05 10:06:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:06:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/729
Author: @manevich
Created: 8/18/2016
Status: ✅ Merged
Merged: 8/18/2016
Merged by: @netblue30

Base: master ← Head: no-sandbox

📝 Commits (1)

3f69d4f run_no_sandbox fix

📊 Changes

3 files changed (+110 additions, -44 deletions)

View changed files

📝 src/firejail/firejail.h (+1 -0)
📝 src/firejail/no_sandbox.c (+108 -43)
📝 src/firejail/sandbox.c (+1 -1)

📄 Description

Fixed problem with cmdline quoting, (see https://github.com/netblue30/firejail/issues/718#issuecomment-240412040)
To avoid code duplication start_application function from sandbox.c used.
Shell choice taken from SHELL env variable or guessed by guess_shell function.
Parses and honors --shell, --zsh, and --csh functions.

Should fix https://github.com/netblue30/firejail/issues/718

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/729 **Author:** [@manevich](https://github.com/manevich) **Created:** 8/18/2016 **Status:** ✅ Merged **Merged:** 8/18/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `no-sandbox` --- ### 📝 Commits (1) - [`3f69d4f`](https://github.com/netblue30/firejail/commit/3f69d4f42c45bfca9e68f9c3fec02edd0ae53c07) run_no_sandbox fix ### 📊 Changes **3 files changed** (+110 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/firejail.h` (+1 -0) 📝 `src/firejail/no_sandbox.c` (+108 -43) 📝 `src/firejail/sandbox.c` (+1 -1) </details> ### 📄 Description Fixed problem with cmdline quoting, (see https://github.com/netblue30/firejail/issues/718#issuecomment-240412040) To avoid code duplication `start_application` function from `sandbox.c` used. Shell choice taken from `SHELL` env variable or guessed by `guess_shell` function. Parses and honors `--shell`, `--zsh`, and `--csh` functions. Should fix https://github.com/netblue30/firejail/issues/718 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:06:56 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3735

No description provided.

Rows
Columns