[PR #709] [MERGED] Gather shell selection code in one place #3723

New issue

Closed

opened 2026-05-05 10:06:45 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:06:45 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/709
Author: @manevich
Created: 8/13/2016
Status: ✅ Merged
Merged: 8/14/2016
Merged by: @netblue30

Base: master ← Head: shell

📝 Commits (3)

9614b8a shell selection
ba27a76 small fix
9f5dfa5 join fixes

📊 Changes

8 files changed (+86 additions, -92 deletions)

View changed files

📝 src/firejail/bandwidth.c (+5 -3)
📝 src/firejail/env.c (+0 -4)
📝 src/firejail/firejail.h (+1 -2)
📝 src/firejail/fs.c (+7 -8)
📝 src/firejail/fs_home.c (+3 -2)
📝 src/firejail/join.c (+12 -35)
📝 src/firejail/main.c (+54 -25)
📝 src/firejail/sandbox.c (+4 -13)

📄 Description

Shell selection code scattered everywere in code and causes bugs like this https://github.com/netblue30/firejail/issues/703.
So:

new guess_shell function
shell selection done once (well, except join), kept in cfg.shell variable.
check for /bin/bash in chroot re-enabled as check for cfg.shell

For now calls guess_shell independently; also I noted that join never honored --shell and --shell=none. Will try to fix this latter.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/709 **Author:** [@manevich](https://github.com/manevich) **Created:** 8/13/2016 **Status:** ✅ Merged **Merged:** 8/14/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `shell` --- ### 📝 Commits (3) - [`9614b8a`](https://github.com/netblue30/firejail/commit/9614b8ac4bf2661f6378abc7db18169fb867d6bb) shell selection - [`ba27a76`](https://github.com/netblue30/firejail/commit/ba27a763ad86978857a8c50bdd83a9bf894e74d7) small fix - [`9f5dfa5`](https://github.com/netblue30/firejail/commit/9f5dfa5964f82fa03b5b86c705b1f599c9887316) join fixes ### 📊 Changes **8 files changed** (+86 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/bandwidth.c` (+5 -3) 📝 `src/firejail/env.c` (+0 -4) 📝 `src/firejail/firejail.h` (+1 -2) 📝 `src/firejail/fs.c` (+7 -8) 📝 `src/firejail/fs_home.c` (+3 -2) 📝 `src/firejail/join.c` (+12 -35) 📝 `src/firejail/main.c` (+54 -25) 📝 `src/firejail/sandbox.c` (+4 -13) </details> ### 📄 Description Shell selection code scattered everywere in code and causes bugs like this https://github.com/netblue30/firejail/issues/703. So: - new `guess_shell` function - shell selection done once (well, except join), kept in `cfg.shell` variable. - check for `/bin/bash` in chroot re-enabled as check for `cfg.shell` For now calls `guess_shell` independently; also I noted that join never honored `--shell` and `--shell=none`. Will try to fix this latter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:06:45 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3723

No description provided.

Rows
Columns