[PR #701] [MERGED] rewrite of X11 support #3722

New issue

Closed

opened 2026-05-05 10:06:45 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:06:45 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/701
Author: @manevich
Created: 8/12/2016
Status: ✅ Merged
Merged: 8/12/2016
Merged by: @netblue30

Base: master ← Head: x11

📝 Commits (2)

6243b04 --x11=xephyr rewrite
702f7b8 --x11=xpra rewrite

📊 Changes

1 file changed (+169 additions, -96 deletions)

View changed files

📝 src/firejail/x11.c (+169 -96)

📄 Description

Sorry for for pull request that can't be automatically merged.
I pulled your latest commits too late. But my rewrite, as seems, also fixes https://github.com/netblue30/firejail/issues/671.

Main points:

no shell used to start commands
don't end starting process. Old behavior can be mimicked by firejail --x11 ... &
wait for jail process to terminate, and then stop X11 processes, this seems to work way better than relying on X11 servers for this.
no problems with stdout/stderr output (except of xpra being noisy)
firejail --x11 --audit works, leaving no dormant X11 servers behind
should fix https://github.com/netblue30/firejail/issues/671, https://github.com/netblue30/firejail/issues/693, https://github.com/netblue30/firejail/issues/648

P.S: I used firejail --x11 echo and firejail --x11=xephyr echo to test edge case "GUI program that failed before opening any X11 connection".

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/701 **Author:** [@manevich](https://github.com/manevich) **Created:** 8/12/2016 **Status:** ✅ Merged **Merged:** 8/12/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `x11` --- ### 📝 Commits (2) - [`6243b04`](https://github.com/netblue30/firejail/commit/6243b04031e0d6acad08ad808ebc0a233d1852c3) --x11=xephyr rewrite - [`702f7b8`](https://github.com/netblue30/firejail/commit/702f7b804f940a271b9eca03f70366eae3fe0f60) --x11=xpra rewrite ### 📊 Changes **1 file changed** (+169 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/x11.c` (+169 -96) </details> ### 📄 Description Sorry for for pull request that can't be automatically merged. I pulled your latest commits too late. But my rewrite, as seems, also fixes https://github.com/netblue30/firejail/issues/671. Main points: - no shell used to start commands - don't end starting process. Old behavior can be mimicked by `firejail --x11 ... &` - wait for jail process to terminate, and then stop X11 processes, this seems to work way better than relying on X11 servers for this. - no problems with stdout/stderr output (except of `xpra` being noisy) - `firejail --x11 --audit` works, leaving no dormant X11 servers behind - should fix https://github.com/netblue30/firejail/issues/671, https://github.com/netblue30/firejail/issues/693, https://github.com/netblue30/firejail/issues/648 P.S: I used `firejail --x11 echo` and `firejail --x11=xephyr echo` to test edge case "GUI program that failed before opening any X11 connection". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:06:45 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3722

No description provided.

Rows
Columns