[PR #652] [MERGED] Two fixes to --join behaviour #3699

Closed
opened 2026-05-05 10:06:17 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/652
Author: @manevich
Created: 7/27/2016
Status: Merged
Merged: 7/27/2016
Merged by: @netblue30

Base: masterHead: patch-3


📝 Commits (2)

  • 9750045 Honor --nice option when joining
  • db9e3fa Honor --shell option when joining

📊 Changes

1 file changed (+76 additions, -23 deletions)

View changed files

📝 src/firejail/join.c (+76 -23)

📄 Description

  • Honor --nice option when joining. Fixes https://github.com/netblue30/firejail/issues/632.
    This is simplest implementation, and niceness is set independently on each join:
    firejail --name=test --nice=10
    and then
    firejail --join=test cmd1
    will start cmd1 with default niceness (usually 0).
    firejail --nice=5 --join=test cmd2
    will start cmd2 with niceness 5.
  • Honor --shell option when joining, including --shell=none

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/652 **Author:** [@manevich](https://github.com/manevich) **Created:** 7/27/2016 **Status:** ✅ Merged **Merged:** 7/27/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `patch-3` --- ### 📝 Commits (2) - [`9750045`](https://github.com/netblue30/firejail/commit/9750045412d652076310772266b143b1b289f00e) Honor --nice option when joining - [`db9e3fa`](https://github.com/netblue30/firejail/commit/db9e3fae364eef5720baa98f8263a7563021fb26) Honor --shell option when joining ### 📊 Changes **1 file changed** (+76 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/join.c` (+76 -23) </details> ### 📄 Description - Honor `--nice` option when joining. Fixes https://github.com/netblue30/firejail/issues/632. This is simplest implementation, and niceness is set independently on each join: `firejail --name=test --nice=10` and then `firejail --join=test cmd1` will start `cmd1` with default niceness (usually 0). `firejail --nice=5 --join=test cmd2` will start `cmd2` with niceness 5. - Honor `--shell` option when joining, including `--shell=none` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:06:17 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3699
No description provided.