[PR #297] [MERGED] RPM build fixes #3589

New issue

Closed

opened 2026-05-05 10:04:13 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:04:13 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/297
Author: @jgriffiths
Created: 2/15/2016
Status: ✅ Merged
Merged: 2/16/2016
Merged by: @netblue30

Base: master ← Head: rpmfixes

📝 Commits (5)

497b755 Update spec file
d684d99 Fix mkrpm.sh
0e68e84 'make rpms' now makes the rpm files
ba35f89 Remove old-mkrpm.sh
f5558dd make clean now removes rpms

📊 Changes

5 files changed (+46 additions, -881 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 Makefile.in (+5 -1)
📝 platform/rpm/firejail.spec (+13 -148)
📝 platform/rpm/mkrpm.sh (+27 -282)
➖ platform/rpm/old-mkrpm.sh (+0 -450)

📄 Description

Fixes the issues noted in issue #296 and in particular brings rpm building into the make system. With these changes the sequence './configure && make rpms' produces the app/debug/source rpms in cwd. I have built and installed the resulting rpm on Fedora 23 and verified that it works running Firefox.

More generally this removes redundant information that needs to be kept up to date manually, e.g. the version is passed by the Makefile automatically and added to the spec rather than being duplicated there. A future enhancement could add always-up-to-date changelog entries by munging RELNOTES.

Finally, this version is much, much simpler than the existing scripts at only 40 LOC.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/297 **Author:** [@jgriffiths](https://github.com/jgriffiths) **Created:** 2/15/2016 **Status:** ✅ Merged **Merged:** 2/16/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `rpmfixes` --- ### 📝 Commits (5) - [`497b755`](https://github.com/netblue30/firejail/commit/497b755f6edd8a28af42dff02aaf2b7b7c49a546) Update spec file - [`d684d99`](https://github.com/netblue30/firejail/commit/d684d9988bcc56e376cf89e51160d10ac8c9c9ff) Fix mkrpm.sh - [`0e68e84`](https://github.com/netblue30/firejail/commit/0e68e84abe652e46827c6b6e0a91679e794c2524) 'make rpms' now makes the rpm files - [`ba35f89`](https://github.com/netblue30/firejail/commit/ba35f8991bea62c91a93c6aa4caa4820d7e4bde6) Remove old-mkrpm.sh - [`f5558dd`](https://github.com/netblue30/firejail/commit/f5558ddc653aeeb8c99e00ebd9c054d496e23655) make clean now removes rpms ### 📊 Changes **5 files changed** (+46 additions, -881 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `Makefile.in` (+5 -1) 📝 `platform/rpm/firejail.spec` (+13 -148) 📝 `platform/rpm/mkrpm.sh` (+27 -282) ➖ `platform/rpm/old-mkrpm.sh` (+0 -450) </details> ### 📄 Description Fixes the issues noted in issue #296 and in particular brings rpm building into the make system. With these changes the sequence './configure && make rpms' produces the app/debug/source rpms in cwd. I have built and installed the resulting rpm on Fedora 23 and verified that it works running Firefox. More generally this removes redundant information that needs to be kept up to date manually, e.g. the version is passed by the Makefile automatically and added to the spec rather than being duplicated there. A future enhancement could add always-up-to-date changelog entries by munging RELNOTES. Finally, this version is much, much simpler than the existing scripts at only 40 LOC. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:04:13 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3589

No description provided.

Rows
Columns