[PR #48] [MERGED] Rewrite globbing code to fix various minor issues #3524

New issue

Closed

opened 2026-05-05 10:03:01 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:03:01 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/48
Author: @sarneaud
Created: 8/28/2015
Status: ✅ Merged
Merged: 8/30/2015
Merged by: @netblue30

Base: master ← Head: glob

📝 Commits (1)

7415d03 Rewrite globbing code to fix various minor issues

📊 Changes

2 files changed (+19 additions, -22 deletions)

View changed files

📝 etc/disable-history.inc (+1 -8)
📝 src/firejail/fs.c (+18 -14)

📄 Description

Plug a memory leak.
Remove the short-circuit. (This breaks when someone uses [] or ?
patterns without using *. I figure it's best to use the principle of
least surprise and just let the system glob() implementation do what
it does.)
Stop sorting results.

I've also replaced a lot of disable-history.inc with a glob pattern.
Now it catches files like .sqlite_history and whatever the user runs
under rlwrap.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/48 **Author:** [@sarneaud](https://github.com/sarneaud) **Created:** 8/28/2015 **Status:** ✅ Merged **Merged:** 8/30/2015 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `glob` --- ### 📝 Commits (1) - [`7415d03`](https://github.com/netblue30/firejail/commit/7415d03df0362a08b4ccf405f8f98147c76e6329) Rewrite globbing code to fix various minor issues ### 📊 Changes **2 files changed** (+19 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `etc/disable-history.inc` (+1 -8) 📝 `src/firejail/fs.c` (+18 -14) </details> ### 📄 Description - Plug a memory leak. - Remove the short-circuit. (This breaks when someone uses [] or ? patterns without using *. I figure it's best to use the principle of least surprise and just let the system glob() implementation do what it does.) - Stop sorting results. I've also replaced a lot of disable-history.inc with a glob pattern. Now it catches files like .sqlite_history and whatever the user runs under rlwrap. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:03:01 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3524

No description provided.

Rows
Columns