[PR #35] [MERGED] Compile with -W -Wall -Werror #3519

New issue

Closed

opened 2026-05-05 10:02:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:02:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/35
Author: @ghost
Created: 8/20/2015
Status: ✅ Merged
Merged: 8/20/2015
Merged by: @netblue30

Base: master ← Head: warnings-cleanup

📝 Commits (1)

48af011 Compile with -W -Wall -Werror

📊 Changes

17 files changed (+49 additions, -33 deletions)

View changed files

📝 src/firejail/Makefile.in (+1 -1)
📝 src/firejail/fs.c (+1 -1)
📝 src/firejail/main.c (+2 -2)
📝 src/firejail/netfilter.c (+1 -1)
📝 src/firejail/profile.c (+1 -1)
📝 src/firejail/sandbox.c (+3 -0)
📝 src/firejail/seccomp.c (+1 -1)
📝 src/firejail/util.c (+3 -2)
📝 src/firemon/Makefile.in (+1 -1)
📝 src/firemon/firemon.c (+3 -0)
📝 src/firemon/netstats.c (+1 -1)
📝 src/firemon/top.c (+7 -4)
📝 src/ftee/Makefile.in (+1 -1)
📝 src/lib/Makefile.in (+1 -1)
📝 src/lib/libnetlink.c (+8 -8)
📝 src/lib/pid.c (+13 -7)
📝 src/libtrace/Makefile.in (+1 -1)

📄 Description

Firejail now compiles with the -W -Wall -Werror option in CFLAGS. This option enables all warnings and turns them into errors, i.e. the compile stops if there are any warnings. I've removed all existing warnings so the code is now clean, and this means that in future the code will remain clean (as it's now impossible to introduce new warnings without breaking the build).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/35 **Author:** [@ghost](https://github.com/ghost) **Created:** 8/20/2015 **Status:** ✅ Merged **Merged:** 8/20/2015 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `warnings-cleanup` --- ### 📝 Commits (1) - [`48af011`](https://github.com/netblue30/firejail/commit/48af0110f88d63bc351579974ceafde352ebe8e2) Compile with -W -Wall -Werror ### 📊 Changes **17 files changed** (+49 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/Makefile.in` (+1 -1) 📝 `src/firejail/fs.c` (+1 -1) 📝 `src/firejail/main.c` (+2 -2) 📝 `src/firejail/netfilter.c` (+1 -1) 📝 `src/firejail/profile.c` (+1 -1) 📝 `src/firejail/sandbox.c` (+3 -0) 📝 `src/firejail/seccomp.c` (+1 -1) 📝 `src/firejail/util.c` (+3 -2) 📝 `src/firemon/Makefile.in` (+1 -1) 📝 `src/firemon/firemon.c` (+3 -0) 📝 `src/firemon/netstats.c` (+1 -1) 📝 `src/firemon/top.c` (+7 -4) 📝 `src/ftee/Makefile.in` (+1 -1) 📝 `src/lib/Makefile.in` (+1 -1) 📝 `src/lib/libnetlink.c` (+8 -8) 📝 `src/lib/pid.c` (+13 -7) 📝 `src/libtrace/Makefile.in` (+1 -1) </details> ### 📄 Description Firejail now compiles with the `-W -Wall -Werror` option in `CFLAGS`. This option enables all warnings and turns them into errors, i.e. the compile stops if there are any warnings. I've removed all existing warnings so the code is now clean, and this means that in future the code will remain clean (as it's now impossible to introduce new warnings without breaking the build). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:02:56 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:26:37 -06:00

[PR #3519] [MERGED] Hardend Signal desktop profile #4789

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3519

No description provided.

Rows
Columns