github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions 6

[GH-ISSUE #6619] build: building with --disable-sandbox-check breaks tests #3313

New issue
Open
opened 2026-05-05 09:54:20 -06:00 by gitea-mirror · 3 comments
gitea-mirror commented 2026-05-05 09:54:20 -06:00
Owner
Copy link

Originally created by @kmk3 on GitHub (Jan 16, 2025).
Original GitHub issue: https://github.com/netblue30/firejail/issues/6619

Description

Building with --disable-sandbox-check breaks the following tests:

  • test/appimage/appimage-v2.exp
  • test/environment/firejail-in-firejail.exp
  • test/environment/umask.exp

Steps to Reproduce

./configure --disable-sandbox-check

From test_main:

test_main build errors 

make -C test appimage
make[1]: Entering directory '/home/runner/work/firejail/firejail/test'
cd appimage && ./appimage.sh 2>&1 | tee appimage.log
TESTING: AppImage v2 (test/appimage/appimage-v2.exp)
spawn /bin/bash
firejail --name=test --appimage hello-x86_64.AppImage
runner@fv-az700-649:~/work/firejail/firejail/test/appimage$ 
<rejail --name=test --appimage hello-x86_64.AppImage
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-programs.inc
Reading profile /etc/firejail/landlock-common.inc

** Note: you can use --noprofile to disable default.profile **

firejail version 0.9.73

Parent pid 5002, child pid 5005

** Warning: dropping all Linux capabilities and setting NO_NEW_PRIVS prctl **

Mounting appimage type 2
Base filesystem installed in 65.65 ms
]0;firejail hello-x86_64.AppImage Child process initialized in 112.47 ms
Hello, World!
firejail: ../../src/firejail/util.c:1039: create_empty_dir_as_root: Assertion `s.st_uid == 0' failed.
Aborted (core dumped)
Hello, again!
TESTING ERROR 1

From test_environment:

test_environment build errors 

TESTING: firejail in firejail - single sandbox (test/environment/firejail-in-firejail.exp)
spawn /bin/bash
firejail
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ firejail
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-programs.inc
Reading profile /etc/firejail/landlock-common.inc

** Note: you can use --noprofile to disable default.profile **

firejail version 0.9.73

Parent pid 4728, child pid 4729
Base filesystem installed in 64.86 ms
]0;firejail /bin/bashChild process initialized in 103.44 ms
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ firejail
firejail: ../../src/firejail/util.c:1039: create_empty_dir_as_root: Assertion `s.st_uid == 0' failed.
Aborted (core dumped)
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ TESTING ERROR 2

TESTING: retain umask (test/environment/umask.exp)
spawn /bin/bash
firejail --noprofile
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ 
<ail/firejail/test/environment$ firejail --noprofile
firejail version 0.9.73

Parent pid 5204, child pid 5205
Base filesystem installed in 0.06 ms
]0;firejail /bin/bashChild process initialized in 6.42 ms
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ umask
0123
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ firejail
firejail: ../../src/firejail/util.c:1039: create_empty_dir_as_root: Assertion `(s.st_mode & 07777) == (mode)' failed.
Aborted (core dumped)
runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ TESTING ERROR 2

Environment

  • Name/version/arch of the Linux kernel (uname -srm): Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64
  • Name/version of the Linux distribution (e.g. "Ubuntu 20.04" or "Arch Linux"):
    Ubuntu 22.04.5 LTS
  • Name/version of the C compiler (e.g. "gcc 14.1.1-1"): gcc 12.3.0-1ubuntu1~22.04
  • Name/version of the libc (e.g. "glibc 2.40-1"): libc-bin 2.35-0ubuntu3.8
  • Name/version of the Linux API headers (e.g. "linux-api-headers 6.10-1" on
    Arch Linux): ?
  • Version of the source code being built (git rev-parse HEAD):
    a53de4926b

Relates to:

Originally created by @kmk3 on GitHub (Jan 16, 2025). Original GitHub issue: https://github.com/netblue30/firejail/issues/6619 ### Description Building with `--disable-sandbox-check` breaks the following tests: * test/appimage/appimage-v2.exp * test/environment/firejail-in-firejail.exp * test/environment/umask.exp ### Steps to Reproduce ```sh ./configure --disable-sandbox-check ``` From [`test_main`](https://github.com/netblue30/firejail/actions/runs/12744018883/job/35515123076): <details> <summary>test_main build errors</summary> <p> ``` make -C test appimage make[1]: Entering directory '/home/runner/work/firejail/firejail/test' cd appimage && ./appimage.sh 2>&1 | tee appimage.log TESTING: AppImage v2 (test/appimage/appimage-v2.exp) spawn /bin/bash firejail --name=test --appimage hello-x86_64.AppImage runner@fv-az700-649:~/work/firejail/firejail/test/appimage$ <rejail --name=test --appimage hello-x86_64.AppImage Reading profile /etc/firejail/default.profile Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-programs.inc Reading profile /etc/firejail/landlock-common.inc ** Note: you can use --noprofile to disable default.profile ** firejail version 0.9.73 Parent pid 5002, child pid 5005 ** Warning: dropping all Linux capabilities and setting NO_NEW_PRIVS prctl ** Mounting appimage type 2 Base filesystem installed in 65.65 ms ]0;firejail hello-x86_64.AppImage Child process initialized in 112.47 ms Hello, World! firejail: ../../src/firejail/util.c:1039: create_empty_dir_as_root: Assertion `s.st_uid == 0' failed. Aborted (core dumped) Hello, again! TESTING ERROR 1 ``` <p> </details> From [`test_environment`](https://github.com/netblue30/firejail/actions/runs/12744018883/job/35515122427): <details> <summary>test_environment build errors</summary> <p> ``` TESTING: firejail in firejail - single sandbox (test/environment/firejail-in-firejail.exp) spawn /bin/bash firejail runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ firejail Reading profile /etc/firejail/default.profile Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-programs.inc Reading profile /etc/firejail/landlock-common.inc ** Note: you can use --noprofile to disable default.profile ** firejail version 0.9.73 Parent pid 4728, child pid 4729 Base filesystem installed in 64.86 ms ]0;firejail /bin/bashChild process initialized in 103.44 ms runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ firejail firejail: ../../src/firejail/util.c:1039: create_empty_dir_as_root: Assertion `s.st_uid == 0' failed. Aborted (core dumped) runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ TESTING ERROR 2 ``` ``` TESTING: retain umask (test/environment/umask.exp) spawn /bin/bash firejail --noprofile runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ <ail/firejail/test/environment$ firejail --noprofile firejail version 0.9.73 Parent pid 5204, child pid 5205 Base filesystem installed in 0.06 ms ]0;firejail /bin/bashChild process initialized in 6.42 ms runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ umask 0123 runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ firejail firejail: ../../src/firejail/util.c:1039: create_empty_dir_as_root: Assertion `(s.st_mode & 07777) == (mode)' failed. Aborted (core dumped) runner@fv-az1269-744:~/work/firejail/firejail/test/environment$ TESTING ERROR 2 ``` </p> </details> ### Environment - Name/version/arch of the Linux kernel (`uname -srm`): `Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64` - Name/version of the Linux distribution (e.g. "Ubuntu 20.04" or "Arch Linux"): Ubuntu 22.04.5 LTS - Name/version of the C compiler (e.g. "gcc 14.1.1-1"): gcc 12.3.0-1ubuntu1~22.04 - Name/version of the libc (e.g. "glibc 2.40-1"): libc-bin 2.35-0ubuntu3.8 - Name/version of the Linux API headers (e.g. "linux-api-headers 6.10-1" on Arch Linux): ? - Version of the source code being built (`git rev-parse HEAD`): a53de4926bcd74e59016b63455b6b87f03e5557c Relates to: * #6592
gitea-mirror added the
bug
 label 2026-05-05 09:54:20 -06:00
gitea-mirror commented 2026-05-05 09:54:22 -06:00
Author
Owner
Copy link

@powerjungle commented on GitHub (Jan 19, 2025):

Oh sorry, I totally forgot about the tests, my bad! 😓 I assumed that when the pull request tests pass, it's fine, but apparently not. I should've looked into it beforehand. I'll take a look now if I can contribute anything since my PR broke them.

<!-- gh-comment-id:2600870309 --> @powerjungle commented on GitHub (Jan 19, 2025): Oh sorry, I totally forgot about the tests, my bad! 😓 I assumed that when the pull request tests pass, it's fine, but apparently not. I should've looked into it beforehand. I'll take a look now if I can contribute anything since my PR broke them.
gitea-mirror commented 2026-05-05 09:54:23 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Jan 20, 2025):

Oh sorry, I totally forgot about the tests, my bad! 😓 I assumed that when
the pull request tests pass, it's fine, but apparently not.

--disable-sandbox-check modifies the source code, so a CI job would have to
explicitly build firejail with such a configuration in order to check whether
it passes the tests.

It would be nice to have a CI job for it, though there are many PRs open
already and I have a WIP branch that touches on related CI code, so please
avoid opening a PR for this for now.

I should've looked into it beforehand. I'll take a look now if I can
contribute anything since my PR broke them.

Besides the tests themselves, it's unclear to me if there are potential
security implications when using --disable-sandbox-check.

Could you look into it and see if/how it relates to the failed tests?

<!-- gh-comment-id:2602047066 --> @kmk3 commented on GitHub (Jan 20, 2025): > Oh sorry, I totally forgot about the tests, my bad! 😓 I assumed that when > the pull request tests pass, it's fine, but apparently not. `--disable-sandbox-check` modifies the source code, so a CI job would have to explicitly build firejail with such a configuration in order to check whether it passes the tests. It would be nice to have a CI job for it, though there are many PRs open already and I have a WIP branch that touches on related CI code, so please avoid opening a PR for this for now. > I should've looked into it beforehand. I'll take a look now if I can > contribute anything since my PR broke them. Besides the tests themselves, it's unclear to me if there are potential security implications when using `--disable-sandbox-check`. Could you look into it and see if/how it relates to the failed tests?
gitea-mirror commented 2026-05-05 09:54:24 -06:00
Author
Owner
Copy link

@powerjungle commented on GitHub (Jan 20, 2025):

Besides the tests themselves, it's unclear to me if there are potential
security implications when using --disable-sandbox-check.

I will look into it a bit deeper, but like I said in the PR introducing the argument, the reason I wanted it, was to develop and test firejail inside of a sandbox. I wouldn't want anyone to use it in production like that.

<!-- gh-comment-id:2602153920 --> @powerjungle commented on GitHub (Jan 20, 2025): > Besides the tests themselves, it's unclear to me if there are potential security implications when using --disable-sandbox-check. I will look into it a bit deeper, but like I said in the PR introducing the argument, the reason I wanted it, was to develop and test firejail inside of a sandbox. I wouldn't want anyone to use it in production like that.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
serialize_remounts_v2
landlock_v4
landlock
release-0.9.64
release-0.9.62
gitlab_ci
LTSbase
fred_ctests
docs
0.9.80
0.9.80-rc1
0.9.78
0.9.76
0.9.76-rc4
0.9.76-rc3
0.9.76-rc2
0.9.76-rc1
0.9.74
landlock-split
0.9.72
0.9.72rc1
0.9.70
0.9.68
0.9.68rc1
0.9.66
0.9.66rc1
0.9.64.4
0.9.64.2
0.9.64
0.9.64rc1
0.9.62.4
0.9.62.2
0.9.62
0.9.56.2-LTS
0.9.60
0.9.60-rc1
0.9.58.2
0.9.58
0.9.58-rc1
0.9.56-LTS-release
0.9.56-LTS
0.9.56
0.9.56-rc1
0.9.54
0.9.54-rc2
0.9.54-rc1
0.9.52
0.9.38.12
0.9.50
0.9.50-rc1
0.9.48
0.9.46
0.9.46-rc1
0.9.44.10
0.9.44.8
0.9.44.6
0.9.38.10
0.9.44.4
0.9.38.8
0.9.44.2
0.9.44
0.9.44-rc1
0.9.38.4
0.9.42
0.9.42-rc2
0.9.38.2
0.9.42-rc1
disable-globalcfg
0.9.40
0.9.40-rc1
0.9.38
0.9.38-rc1
0.9.36
0.9.36-rc1
0.9.34
0.9.34-rc1
0.9.32
0.9.32-rc1
0.9.30
0.9.30-rc1
Labels
Clear labels   
LTS merge

   
LTS merge

   
bug

   
bug

   
converted-to-discussion

   
doc-todo

   
documentation

   
duplicate

   
enhancement

   
file-transfer

   
firecfg

   
firejail-in-firejail

   
firetools

   
graphics

   
help wanted

   
information_old

   
installation

   
invalid

   
modif

   
moved

   
needinfo

   
networking

   
notabug

   
notourbug

   
old-version

   
overlayfs

   
packaging

   
profile-request

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question_old

   
removal

   
runtime-permissions

   
sandbox-ipc

   
security

   
stale

   
wiki

   
wiki

   
wontfix

   
wordpress

   
workaround
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3313
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?