mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #5877] nextcloud: cannot access ~/Nextcloud/Notes #3120
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#3120
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Sadoon-AlBader on GitHub (Jul 2, 2023).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5877
Description
The default settings allow NC to only access the parent directory ${HOME}/Nextcloud and not any of its subdirs.
Steps to Reproduce
No errors, in command line, Nextcloud complains that it cannot access i.e. "{HOME}/Nextcloud/Notes"
Verified that it can access {HOME}/Nextcloud by commenting out "noblacklist {HOME}/Nextcloud" and it gives a different error.
Expected behavior
It should have access to all subdirs by default
Actual behavior
No access to any subdirs.
Behavior without a profile
Works just fine.
Environment
Checklist
/usr/bin/vlc) "fixes" it).https://github.com/netblue30/firejail/issues/1139)browser-allow-drm yes/browser-disable-u2f noinfirejail.configto allow DRM/U2F in browsers.--profile=PROFILENAMEto set the right profile. (Only relevant for AppImages)Log
Not necessary, no log errors.
I think all we need is a * after the Nextcloud, either that or my configuration is hopelessly broken. All other programs seems to work fine though and I have no custom settings from what I can tell. Thanks for this software btw!
@rusty-snake commented on GitHub (Jul 2, 2023):
Just test and know.
@Sadoon-AlBader commented on GitHub (Jul 2, 2023):
Ah my bad, forgot to mention I already tried the solution I mentioned in a nextcloud.local config and it works fine.
I'd send a patch but I want to make sure this is not just affecting me before messing with it everyone else's configs :)
@rusty-snake commented on GitHub (Jul 2, 2023):
Actually you only need to
noblacklist33c75b8932/etc/inc/disable-programs.inc (L1189)@Sadoon-AlBader commented on GitHub (Jul 2, 2023):
Ah strange, I'd never assumed that /Notes specifically would be blacklisted in a general include file, my bad.
Edit: Although it does make perfect sense to not blacklist that folder in Nextcloud's config by default.
@kmk3 commented on GitHub (Jul 4, 2023):
Edit: Nevermind this comment, the diff looks OK:
@rusty-snake on Jul 2:
That lineThenoblacklistline existed but it seems to have been removedin a merge commit that accidentally truncated some files. The merge commit was
followed by its revert, which did not restore the affected line:
7c481eb43("Add QOwnNotes profile", 2018-10-20) by @Fred-Barclay0d42e12f1("Merge branch 'master' of github.com:netblue30/firejail",2019-04-24) by @rusty-snake
590f66171("Revert "Merge branch 'master' of github.com:netblue30/firejail"",2019-04-24) by @SkewedZeppelin
This seems a bit worrying, as more changes might have been lost.
Does anyone remember what happened there?
I might look into this later.
@rusty-snake commented on GitHub (Jul 4, 2023):
I don't know what your talking about the line was restored in the revert (
590f661715 (diff-de6116e8cecbb92d4cb33c3294352b83db4bf33a48306f6f862e51d4c7181f91R7)) and it exists on current master (https://github.com/netblue30/firejail/blob/master/etc/inc/disable-programs.inc#L1189).@kmk3 commented on GitHub (Jul 4, 2023):
Sorry, I meant the
noblacklist ${HOME}/Nextcloud/Notesthat you suggested:@rusty-snake commented on GitHub (Jul 4, 2023):
Neither nextcloud.profile nor QOwnNotes.profile are touched in the commits above.
@kmk3 commented on GitHub (Jul 4, 2023):
Sorry, please disregard all that. It seems that I confused the
commands/outputs. The diff from before the merge/after the revert looks
normal:
git diff
The
git log -Scommand was wrong; the search also counted theblacklistcommand. This is more accurate:
The
noblacklist ${HOME}/Nextcloud/Notesline is still in that profile:So I suppose that it only needs to be copied to nextcloud.profile then.