mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #5817] firefox: browser notifications do not appear in KDE notifications #3101
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#3101
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mYnDstrEAm on GitHub (May 4, 2023).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5817
Description
I'm using Debian11 with KDE.
When one configures "Do not disturb" in KDE's notification settings in the plasma panel, notifications from the browser can still pop up on the screen, including on the desktop.
Other notification settings are also rendered ineffective, for example timeouts for the popups and so on. They also look different than all the other notifications (inconsistent) and are at another place of the screen (upper right instead of bottom right).
This also is a privacy and security issue because if you expect them to be hidden, they could display unwanted info to others who see your screen (locally or during presentations for example).
Described it here before here I noticed it's a firejail issue.
Steps to Reproduce
Steps to reproduce the behavior
Expected behavior
It should display the browser notifications as KDE notifications (and depending on KDE notification settings) and they should be hidden when Do not disturb is enabled.
Actual behavior
It does display the browser notifications not as KDE notifications and they aren't hidden when Do not disturb is enabled.
Behavior without a profile
Without firejail the notifications display fine.
Additional context
Environment
Checklist
/usr/bin/vlc) "fixes" it).https://github.com/netblue30/firejail/issues/1139)browser-allow-drm yes/browser-disable-u2f noinfirejail.configto allow DRM/U2F in browsers.--profile=PROFILENAMEto set the right profile. (Only relevant for AppImages)Log
Output of
LC_ALL=C firejail /path/to/programOutput of
LC_ALL=C firejail --debug /path/to/program@rusty-snake commented on GitHub (May 4, 2023):
a2c8a5f03c/etc/profile-a-l/firefox.profile (L57-L58)@rusty-snake commented on GitHub (May 4, 2023):
Duplicated of #3465 and some other I guess.
@mYnDstrEAm commented on GitHub (May 4, 2023):
Thanks. However, a commented-out line in some profile file is not a solution. It should be uncommented by default or be used depending on some conditions (like whether it detected that KDE is used).
At a minimum, the user needs to be made aware of this setting, for example by showing a prompt (if KDE is detected or for all users) after installation/package-upgrade like "Should notifications displays as KDE's native notifications? [yes] [no]".
@ghost commented on GitHub (May 4, 2023):
Implementing such
desktop-aware conditionalswould indeed be beneficial from a UX perspective. Probably even better when it could happen atruntime. Installing KDE (or any other DE) does not imply it is actively being used.@kmk3 commented on GitHub (May 4, 2023):
@mYnDstrEAm on May 4:
It is commented because it's apparently very unsafe, as explained in #3465.
Maybe there could be a toggle for desktop notifications in firejail.config
similar to
allow-tray.But note that such a tradeoff applies to many other profiles as well, so it is
more scalable to add customizations as needed than to create and maintain
dozens or hundreds of prompts.
Also, note that everyone has a different security/convenience tradeoff
preference and the profiles cannot possibly match all of them at the same time;
users are expected to read, understand and tune the profiles to their needs.
@kmk3 commented on GitHub (May 4, 2023):
(Closing as a duplicate of #3465)
@mYnDstrEAm commented on GitHub (May 4, 2023):
Why is this and/or the other issue closed as completed when the decision seems to be
...and it's not fixed? I don't think it should be closed before either:
Also the other issue is not really a duplicate as it's more about the appearance and not about the notifications displaying according to the DE's notification settings, including being hidden when "Do not disturb" is enabled, which is a privacy and security issue. Until at least an issue is opened elsewhere I suggest reopening one of the two issues.
@kmk3 commented on GitHub (May 4, 2023):
@mYnDstrEAm on May 4:
This is not "closed as completed"; it is closed as "not planned" because the
profile is working as intended. The same applies to the other issue, which was
closed before "not planned" existed.
Sure, how can that be done then? If there is no way to do it in firejail, then
there is nothing to be done here and the issues should be closed, as this is
documented in the profile and the same thing applies to many other profiles.
If you do find out a way, then feel free to post it in #3465.
Sounds like a good idea; feel free to do so.
The root cause and the workaround are the same in both issues, so they are
duplicates from the point of view of the project. I updated the labels in
#3465 as well.
If firejail/the profiles are working as intended, then the issue is closed as
"notabug".
Issues that are caused by a third-party are closed as "notourbug", since they
are usually not actionable here until the issues are fixed (and/or because it
would make more sense to fix the issues elsewhere).
If you want to propose a specific feature related to this, then see:
@mYnDstrEAm commented on GitHub (May 12, 2023):
Reopened my issue at KDE here: https://bugs.kde.org/show_bug.cgi?id=457949
If there is a better place to ask about / propose this like at the DBUS repo, please comment where.
Is there something you know of that could be done on the side of KDE or DBUS to solve this problem such as KDE using / also using another system notification service?
However, I suggest that in this case something is done to make the user be aware of that. That's because this is a security and privacy issue if notifications still show with the default firefox profile even when you have "Do not disturb" enabled.