mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #5692] rsync-download_only: private-bin is broken #3066
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#3066
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Feb 27, 2023).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5692
Today I found my first ever use case for rsync-download_only.profile. But
private-bin rsyncis broken on my Arch Linux box (running firejail from git):Obviously
ignore private-binfixes this. But I can't explain whyprivate-bin rsyncreports an error. Testing other apps using private-bin confirm it seems to work as expected. I'll do some more digging but I don't think Arch Linux does anything out of the ordinary packaging rsync compared to other distro's. If anyone can check this on a different distribution that would be helpful. @rusty-snake As you contributed this, can you double-check if private-bin works for you on Fedora please (if that's still your main distro)?[Side note] foo.local refers to rsync.local although the hardening comment uses rsync-download_only.local - which can be easily fixed
854e54fb59/etc/profile-m-z/rsync-download_only.profile (L6)854e54fb59/etc/profile-m-z/rsync-download_only.profile (L25)@kmk3 commented on GitHub (Feb 27, 2023):
Works for me on Artix:
+1
By the way, you can probably keep the
| grep versionhere since the errorsusually go to stderr.
@ghost commented on GitHub (Feb 28, 2023):
@kmk3 Thanks for your response. I do use an additional patch for #5650, but even when I take that out I'm seeing the breakage as posted above. Will have to do more debugging...
@kmk3 commented on GitHub (Feb 28, 2023):
@glitsj16 on Feb 28:
No problem; I'd suggest temporarily installing and testing with the non-git
Arch package (community/firejail 0.9.72-1) to rule out it being caused by
custom patches or regressions on master.
@kmk3 commented on GitHub (Aug 23, 2024):
Hello, is this still an issue?
Are you sure that it's not due to modifications in globals.local, etc?
@ghost commented on GitHub (Aug 23, 2024):
Yes, the issue still shows for me. I've made absolutely sure to temporarily move my *.local files out of the way while testing. It works when I use
private-bin rsync*. Baffled, but there it is :)@kmk3 commented on GitHub (Aug 23, 2024):
Does it work with just the following?
Are you using a wrapper script (such as in ~/bin) for rsync?
Or something that rsync might call, like ssh?
@ghost commented on GitHub (Aug 23, 2024):
I was aware of /usr/bin/rrsync and /usr/bin/rsync-ssl while re-checking this issue. But no, adding
rsync-sslto private-bin does not solve it. Which is to be expected, because that is a shell script and rsync-download_only.profile blocks that viainclude disable-shell.inc...Re-checked for wrappers, but again, nothing there either.