github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

config.gz blacklisted twice #3029

New issue

Closed

opened 2026-05-05 09:40:43 -06:00 by gitea-mirror · 3 comments

gitea-mirror commented

2026-05-05 09:40:43 -06:00

Owner

Originally created by @ghost on GitHub (Dec 21, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5545

Minor issue with blacklisting kernel configuration:

6e67801a45/etc/inc/disable-common.inc (L624)

6e67801a45/etc/inc/disable-proc.inc (L11)

Not sure which of these include files would be the better place for it. I've checked our profiles and there are zero files that include disable-proc.inc without also including disable-common.inc, so it won't be a lot of work to remove it from one or the other. Or am I missing something here and it's supposed to be like this?

Originally created by @ghost on GitHub (Dec 21, 2022). Original GitHub issue: https://github.com/netblue30/firejail/issues/5545 Minor issue with blacklisting kernel configuration: https://github.com/netblue30/firejail/blob/6e67801a4592494d3d24e696f6fe06acc7856d88/etc/inc/disable-common.inc#L624 https://github.com/netblue30/firejail/blob/6e67801a4592494d3d24e696f6fe06acc7856d88/etc/inc/disable-proc.inc#L11 Not sure which of these include files would be the better place for it. I've checked our profiles and there are _zero_ files that include disable-proc.inc without also including disable-common.inc, so it won't be a lot of work to remove it from one or the other. Or am I missing something here and it's supposed to be like this?

gitea-mirror closed this issue

2026-05-05 09:40:44 -06:00

gitea-mirror commented

2026-05-05 09:40:46 -06:00

Author

Owner

@kmk3 commented on GitHub (Dec 21, 2022):

Since disable-common.inc is the more, well, common include I'd leave it only
there.

Alternatively, put something like this in disable-proc.inc:

blacklist /proc/config.gz # also in disable-common.inc

To make it clear that the duplication is intentional.

@kmk3 commented on GitHub (Dec 21, 2022): Since disable-common.inc is the more, well, common include I'd leave it only there. Alternatively, put something like this in disable-proc.inc: ```firejail blacklist /proc/config.gz # also in disable-common.inc ``` To make it clear that the duplication is intentional.

gitea-mirror commented

2026-05-05 09:40:47 -06:00

Author

Owner

@rusty-snake commented on GitHub (Dec 21, 2022):

disable-common.inc is the more, well, common include

Correct. But disable-proc should really disable proc and not depend on dc for full functionality.

I'd say dp must have it and we should keep it in dc as legacy blacklist for now.

OT: disable-proc can and should be used in much more profiles.

@rusty-snake commented on GitHub (Dec 21, 2022): >disable-common.inc is the more, well, common include Correct. But disable-proc should really disable proc and not depend on dc for full functionality. I'd say dp must have it and we should keep it in dc as legacy blacklist for now. OT: disable-proc can and should be used in much more profiles.

gitea-mirror commented

2026-05-05 09:40:47 -06:00

Author

Owner

@ghost commented on GitHub (Dec 21, 2022):

disable-proc should really disable proc and not depend on dc for full functionality

Agreed. Now we just made it a bit more visible via the comment. Might avoid future mishaps if someone tries to remove it from dc.

OT: disable-proc can and should be used in much more profiles.

Indeed. Not sure we can do the work to get it into 0.9.72. The same goes for noprinters IMO.

@ghost commented on GitHub (Dec 21, 2022): > disable-proc should really disable proc and not depend on dc for full functionality Agreed. Now we just made it a bit more visible via the comment. Might avoid future mishaps if someone tries to remove it from dc. > OT: disable-proc can and should be used in much more profiles. Indeed. Not sure we can do the work to get it into 0.9.72. The same goes for `noprinters` IMO.

gitea-mirror referenced this issue

2026-05-05 10:23:28 -06:00

[PR #3037] [MERGED] Resolve #3029: drop outdated Skype profile #4617

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3029

No description provided.

Rows
Columns